Enable styles for buttons as well as enable disabling and enabling buttons #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the hassle of making one pull request to all features, but thought it would make sense.
I am currently working on a project and found out that I need to disable the
increment
anddecrement
buttons when the user reaches themax
ormin
values specified.Therefore, the following was done:
1- add expected props to the
typescript interface
following a previous name convention used with the icon styles2- change the
style
prop on theincrement
anddecrement
to be an array3- spread the upcoming props that are related to the button styles if
true
other wise just use{}
4- add a
disabled
prop to the buttons5- write a condition inside the disabled prop that checks if the max/min reached as well if the user passed the disablers props
disableIncButtonOnMaxReach
anddisableDecButtonOnMaxReach
Happy to make any necessary changes after reviewing