not changing local state when parsed value is the same of the previous #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we did this small change to address the user input like 0.01 with the current implementation this is not possible as 0.00 would be resetted to 0. Since 1.01 is equal to 1.0100 just skipping the state update when the real values are the same is enough. In addition I forwarded the original text to the change handler as second parameter, this may be useful for additional logic and would not impact the currents implementations that expect a real number as first parameter of the onChange
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we did this small change to allow user input number like 0.01, with the current implementation this is not possible as 0.00 would be resetted to 0.
Since 1.01 is equal to 1.0100 just skipping the state update when the real values are the same is enough.
In addition I forwarded the original text to the change handler as second parameter, this may be useful for additional logic and would not impact the currents implementations that expect a real number as first parameter of the onChange