Fix issue-94: isMax inverted for keyboard input #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he on limit reached callback
rares-nandra
commented
Dec 4, 2023
| @@ -127,10 +127,10 @@ export default class NumericInput extends Component { | |||
| let legal = match && match[0] === match.input && ((this.props.maxValue === null || (parseFloat(this.state.stringValue) <= this.props.maxValue)) && (this.props.minValue === null || (parseFloat(this.state.stringValue) >= this.props.minValue))) | |||
| if (!legal) { | |||
| if (this.props.minValue !== null && (parseFloat(this.state.stringValue) <= this.props.minValue)) { | |||
| this.props.onLimitReached(true, 'Reached Minimum Value!') | |||
There was a problem hiding this comment.
When the minimum value is reached, isMax should be false
rares-nandra
commented
Dec 4, 2023
| } | ||
| if (this.props.maxValue !== null && (parseFloat(this.state.stringValue) >= this.props.maxValue)) { | ||
| this.props.onLimitReached(false, 'Reached Maximum Value!') |
There was a problem hiding this comment.
When the maximum value is reached, isMax should be true
rares-nandra
commented
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when providing keyboard input the values for isMax were inverted