contract audit fixes #145
Closed
contract audit fixes #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amessbee
reviewed
Dec 10, 2024
contract/src/airdrop.contract.js
Outdated
Comment on lines
26
to
36
| const ProofDataShape = harden({ | ||
| hash: M.string(), | ||
| direction: M.string(), | ||
| }); | ||
|
|
||
| const OfferArgsShape = harden({ | ||
| tier: M.number(), | ||
| address: M.string(), | ||
| key: M.string(), | ||
| proof: M.arrayOf(ProofDataShape), | ||
| }); |
There was a problem hiding this comment.
This looks good. Maybe we can also specify max length as (perhaps limits parameter) for string and arrayOf. WDYT?
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
amessbee
reviewed
Dec 10, 2024
| }); | ||
|
|
||
| const OfferArgsShape = harden({ | ||
| tier: M.number(), |
There was a problem hiding this comment.
tier seems to be defined as bigInt in the contract and not as a number - not sure if that matters.
There was a problem hiding this comment.
ATPIT the tier argument is working correctly within the contract. That said, the tier value is going to be concatenated onto the end of the pubkey hex string rather than being its own argument.
…ng handled correctly when processed through updated offerHandler code
…itedness as generic interface for creating AsyncGenerator subscribtions (#150) This commit contains test for: - Handling bobs offer - Subscribing to bobs wallet - Verifying Alice's inability to make a second claim attempt
tgrecojs
changed the title
|
closing this PR as these fixes were merged in PR #149. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #141, #142