Functional BottomPopup + rendering optimizations #4556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why do we need it? Is it really necessary for release (could solve android performance issues)? |
1 task
|
Yes, I'm hoping to solve Android performance issues. Also, I'll add a fix for #4560 |
southerneer
force-pushed
the
functional-bottom-sheet
branch
from
da3d78e to
fecef1e
Compare
southerneer
changed the title
|
I'm not qualified to review this :) |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to turn BottomPopupNew into a functional component. I was 90% of the way there and then ran into this problem: facebook/react#14042. Listeners added in
useEffect(with no dependencies) can't access current values of state or props. So I need to useuseReducerinstead for the state/props that will be used in that listener to determine when we need to runActions.refresh({preview: true/false}).Probably there are some further simplifications I can throw in to make this a lot easier to digest, but I just wanted to get it working first.