Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge 0.2.2-alpha-1 #5

Merged
merged 3 commits into from
Jan 24, 2021
Merged

Merge 0.2.2-alpha-1 #5

merged 3 commits into from
Jan 24, 2021

Conversation

hipstermojo
Copy link
Owner

This PR contains the following bug fixes:

  • Remove srcset attribute in images. Readers like Foliate will use the values in srcset rather than src which contains the downloaded image.
  • Fix crashes on links with redirects. This makes it possible to now view articles that proxy to Medium articles.

@hipstermojo
Bug fixes
1dc7b34 
The bug fixes include:
- `<html>` nodes being added to the replaced image when `unwrap_noscript_tags`
  is called.
- Remove `srcset` attribute of <img> tags after downloading the image. This
  prevented readers like Foliate from displaying the downloaded image
@hipstermojo
Refactor fetch_url
21c3ffd 
This adds:
- More validation of responses to ensure the HTML response is valid.
- Better handling of redirecting URLs which allows for fetching of
  links proxied to Medium.
@hipstermojo
Bump version
b98c0a6
@hipstermojo hipstermojo merged commit c82071a into master Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hipstermojo