Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache with concurrency #24

Merged
merged 4 commits into from
Oct 16, 2020
Merged

Conversation

po3rin
Copy link
Contributor

@po3rin po3rin commented Oct 16, 2020

Introduce concurrency because cache will be slower by the number of projects.

You can check the progress of parallel processing with the progressbar.

$ bqiam cache
[1/3][project-1] caching datasets... 23 % [======>-----------------------]  10s
[2/3][project-2] caching datasets... 28 % [=======>----------------------]   9s
[3/3][project-3] caching datasets... 27 % [=======>----------------------]   8s

demo

名称未設定

performance

Measured by the amount of practical data.

check

Because parallel processing is included, I checked it with -race just in case

$ go run -race main.go cache


bq "cloud.google.com/go/bigquery"

"github.com/schollz/progressbar/v3"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a short life, haha.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

schollz/progressbar mantainer not supports multi line bar ...
schollz/progressbar#6

@hirosassa
Copy link
Owner

LGTM!

@hirosassa hirosassa merged commit 416e21f into hirosassa:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants