Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add revoke cmd #31

Merged
merged 3 commits into from
Apr 6, 2022
Merged

add revoke cmd #31

merged 3 commits into from
Apr 6, 2022

Conversation

hirosassa
Copy link
Owner

fixes #30

@hirosassa hirosassa changed the title WIP: add revoke cmd add revoke cmd Apr 6, 2022
@hirosassa
Copy link
Owner Author

@snowhork @kitagry I added revoke permission commands. plz review.

kitagry
kitagry reviewed Apr 6, 2022
View reviewed changes
bqrole/project.go Outdated
}
}

defer client.Close()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think client.Close should be called immediately

	client, err := bq.NewClient(ctx, project)
	if err != nil {
		return errors.New("failed to create bigquery Client")
	}
	defer client.Close()

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! fixed

@kitagry
Copy link
Contributor

kitagry commented Apr 6, 2022

LGTM

@snowhork
Copy link
Contributor

snowhork commented Apr 6, 2022

LGTM!

@hirosassa hirosassa merged commit ac2c292 into master Apr 6, 2022
@hirosassa hirosassa deleted the revoke branch April 6, 2022 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitagry kitagry kitagry left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add revoke command.
3 participants
@hirosassa @kitagry @snowhork