fix: comment list pagination

.github/workflows/test.yaml

@@ -20,9 +20,9 @@ jobs:
         with:
           go-version-file: "go.mod"
 
-      - uses: aquaproj/aqua-installer@v2.1.2
+      - uses: aquaproj/aqua-installer@v3.0.0
         with:
-          aqua_version: v2.10.1
+          aqua_version: v2.27.0
 
       - uses: suzuki-shunsuke/github-action-golangci-lint@v0.1.4
       - name: Test

pkg/notifier/gitlab/comment.go

@@ -6,6 +6,11 @@ import (
 	gitlab "github.com/xanzy/go-gitlab"
 )
 
+const (
+	listPerPage = 100
+	maxPages    = 100
+)
+
 // CommentService handles communication with the comment related
 // methods of GitLab API
 type CommentService service
@@ -59,9 +64,36 @@ func (g *CommentService) Patch(note int, body string, opt PostOptions) error {
 
 // List lists comments on GitLab merge requests
 func (g *CommentService) List(number int) ([]*gitlab.Note, error) {
-	comments, _, err := g.client.API.ListMergeRequestNotes(
-		number,
-		&gitlab.ListMergeRequestNotesOptions{},
-	)
-	return comments, err
+	allComments := make([]*gitlab.Note, 0)
+
+	opt := &gitlab.ListMergeRequestNotesOptions{
+		ListOptions: gitlab.ListOptions{
+			Page:    1,
+			PerPage: listPerPage,
+		},
+	}
+
+	for sentinel := 1; ; sentinel++ {
+		comments, resp, err := g.client.API.ListMergeRequestNotes(
+			number,
+			opt,
+		)
+		if err != nil {
+			return nil, err
+		}
+
+		allComments = append(allComments, comments...)
+
+		if resp.NextPage == 0 {
+			break
+		}
+
+		opt.Page = resp.NextPage
+
+		if sentinel > maxPages {
+			return nil, fmt.Errorf("gitlab.comment.list: too many pages, something went wrong")
+		}
+	}
+
+	return allComments, nil
 }

pkg/notifier/gitlab/comment_test.go

@@ -70,6 +70,16 @@ func TestCommentPost(t *testing.T) {
 func TestCommentList(t *testing.T) {
 	t.Parallel()
 	comments := []*gitlab.Note{
+		// page1
+		{
+			ID:   371748792,
+			Body: "comment 1",
+		},
+		{
+			ID:   371765743,
+			Body: "comment 2",
+		},
+		// page2
 		{
 			ID:   371748792,
 			Body: "comment 1",

pkg/notifier/gitlab/gitlab_test.go

@@ -45,6 +45,7 @@ func newFakeAPI() fakeAPI {
 		FakeListMergeRequestNotes: func(mergeRequest int, opt *gitlab.ListMergeRequestNotesOptions, options ...gitlab.RequestOptionFunc) ([]*gitlab.Note, *gitlab.Response, error) {
 			var comments []*gitlab.Note
 			comments = []*gitlab.Note{
+				// same response to any page for now
 				{
 					ID:   371748792,
 					Body: "comment 1",
@@ -54,7 +55,16 @@ func newFakeAPI() fakeAPI {
 					Body: "comment 2",
 				},
 			}
-			return comments, nil, nil
+
+			// fake pagination with 2 pages
+			resp := &gitlab.Response{
+				NextPage: 0,
+			}
+			if opt.Page == 1 {
+				resp.NextPage = 2
+			}
+
+			return comments, resp, nil
 		},
 		FakePostCommitComment: func(sha string, opt *gitlab.PostCommitCommentOptions, options ...gitlab.RequestOptionFunc) (*gitlab.CommitComment, *gitlab.Response, error) {
 			return &gitlab.CommitComment{