Stacks block commitments incorrectly assign change outputs as pox transfers

[aulneau]

Describe the bug

For the block commitments predicate, burn related pox blocks are incorrectly assigning change outputs as pox transfer events:

       "stacks_operations": [
          {
            "block_committed": {
              "block_hash": "0x5b7e468df57b9d0208b67ffd3bc145a48e200270afb94fc8b11d910760276a01",
              "mining_address_post_commit": null,
              "mining_sats_left": 0,
              "pox_cycle_index": 74,
              "pox_cycle_length": 2200,
              "pox_cycle_position": 997,
              "pox_sats_burnt": 501000,
              "pox_sats_transferred": [
                {
                  "amount": 626173985,
                  "recipient_address": "1UiW61F9xnBnnC1J69aPJhFm3ZXvZEkCm"
                }
              ]
            }
          }
        ]

Here is the entire output for a block commitment event for block 829847, and the related transaction: https://mempool.space/tx/151bc0d6ced51f3f7675f0caa60769543f2ec5962f0fe271c14b8c5feca466cf

https://gist.github.com/aulneau/f612837d61cbcc8e12d6d0a4c9ef8c63

seems possible this condition is incorrect:

chainhook/components/chainhook-sdk/src/indexer/bitcoin/mod.rs

Line 514 in 489b014

.is_consensus_rewarding_participants_at_block_height(block_height)

or maybe this logic?

chainhook/components/chainhook-sdk/src/indexer/bitcoin/mod.rs

Lines 551 to 557 in 489b014

	if pox_address_2.to_string().eq(&pox_config.get_burn_address()) {
	pox_sats_burnt += pox_output_2.value.to_sat();
	} else {
	pox_sats_transferred.push(PoxReward {
	recipient_address: pox_address_2.to_string(),
	amount: pox_output_2.value.to_sat(),
	});

[lgalabru]

Thanks @aulneau, we're looking into this.

[MicaiahReid]

Hey @aulneau, great find on this bug!

I have a fix out in PR #499. Would you be able to checkout the branch fix-block-commitment, rebuild Chainhook, and confirm that things are working as expected?

[aulneau]

Hey @aulneau, great find on this bug!

I have a fix out in PR #499. Would you be able to checkout the branch fix-block-commitment, rebuild Chainhook, and confirm that things are working as expected?

Unfortunately I do not have a bitcoin node set up -- I'm using the hiro platform for any bitcoin specific predicates

[MicaiahReid]

@aulneau @lgalabru I've deployed this fix to our dev infrastructure. I made this predicate:

{
  "name": "Test Block Commitment Fix",
  "uuid": "08652ee3-733d-4a27-9442-09b0f142b501",
  "chain": "bitcoin",
  "version": 1,
  "networks": {
    "mainnet": {
      "if_this": { "scope": "stacks_protocol", "operation": "block_committed" },
      "end_block": 829848,
      "then_that": {
        "http_post": {
          "url": "...",
          "authorization_header": ""
        }
      },
      "start_block": 829847,
      "include_proof": false,
      "include_inputs": true,
      "include_outputs": true,
      "include_witness": false,
      "expire_after_occurrence": null
    }
  }
}

and got this output for the block commitment:

"stacks_operations": [
    {
      "block_committed": {
        "block_hash": "0x5b7e468df57b9d0208b67ffd3bc145a48e200270afb94fc8b11d910760276a01",
        "mining_address_post_commit": "1UiW61F9xnBnnC1J69aPJhFm3ZXvZEkCm",
        "mining_sats_left": 626173985,
        "pox_cycle_index": 74,
        "pox_cycle_length": 2200,
        "pox_cycle_position": 997,
        "pox_sats_burnt": 501000,
        "pox_sats_transferred": []
      }
    }
]

We should have this fix pushed to the platform on the next release!

[github-actions]

🎉 This issue has been resolved in version 1.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀