Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sbtc modal #1945

Merged
merged 1 commit into from
Dec 18, 2024
Merged

feat: sbtc modal #1945

merged 1 commit into from
Dec 18, 2024

Conversation

BLuEScioN
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Adding modal for sbtc

Issue ticket number and link

#1944

Checklist:

  • I have performed a self-review of my code.
  • I have tested the change on desktop and mobile.
  • I have added thorough tests where applicable.
  • I've added analytics and error logging where applicable.

Screenshots (if appropriate):

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer-storybook 🔄 Building (Inspect) Visit Preview Dec 18, 2024 9:12pm
hiro-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 9:12pm

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/common/components/modals/SBTCModal.tsx 0.00% 28 Missing and 1 partial ⚠️
src/common/components/modals/Nakamoto.tsx 0.00% 7 Missing and 1 partial ⚠️
src/app/_components/PageWrapper.tsx 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@BLuEScioN BLuEScioN merged commit 65697a1 into main Dec 18, 2024
16 of 18 checks passed
@BLuEScioN BLuEScioN deleted the feat/sbtc-modal branch December 18, 2024 21:41
@blockstack-devops
Copy link

🎉 This PR is included in version 1.239.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

sentry-io bot commented Jan 1, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ReferenceError: Modal is not defined /sandbox/transfer View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants