chore: fix bug with memo hex strings not decoded in Rosetta responses #1292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1292 +/- ##
========================================
Coverage 77.02% 77.03%
========================================
Files 106 106
Lines 10046 10053 +7
Branches 2158 2160 +2
========================================
+ Hits 7738 7744 +6
- Misses 2200 2201 +1
Partials 108 108
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rafaelcr
approved these changes
Aug 24, 2022
Contributor
|
🎉 This PR is included in version 6.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 7.0.0-stacks-2.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug in
developbranch where Rosettamemostrings were no longer decoded from hex.The code was trying to trim NULL bytes from a hex string, which previously used to be a string from
Buffer.from(memoBytes).toString()in v4.This fixes the expected response, and trims bytes off the Buffer before converting to string, rather than depending on undefined behavior with Buffer and trailing null bytes.