Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On CMake 3.24.2 DOWNLOAD_EXTRACT_TIMESTAMP warning appears #15

Closed
widgetii opened this issue Oct 12, 2022 · 1 comment
Closed

On CMake 3.24.2 DOWNLOAD_EXTRACT_TIMESTAMP warning appears #15

widgetii opened this issue Oct 12, 2022 · 1 comment
Assignees

Comments

@widgetii
Copy link

After upgrading to fresh CMake 3.24.2 I got an unpleasant warning:

CMake Warning (dev) at /usr/share/cmake/Modules/FetchContent.cmake:1267 (message):
  The DOWNLOAD_EXTRACT_TIMESTAMP option was not given and policy CMP0135 is
  not set.  The policy's OLD behavior will be used.  When using a URL
  download, the timestamps of extracted files should preferably be that of
  the time of extraction, otherwise code that depends on the extracted
  contents might not be rebuilt if the URL changes.  The OLD behavior
  preserves the timestamps from the archive instead, but this is usually not
  what you want.  Update your project to the NEW behavior or specify the
  DOWNLOAD_EXTRACT_TIMESTAMP option with a value of true to avoid this
  robustness issue.
Call Stack (most recent call first):
  build/_deps/datatype99-src/CMakeLists.txt:6 (FetchContent_Declare)
This warning is for project developers.  Use -Wno-dev to suppress it.

Similar issues and PR suggestions are 1 and 2. Consider adding the same fix into the project.

P.S. The same issue is with interface99 and smolrtsp as well

@hirrolot hirrolot self-assigned this Oct 13, 2022
@hirrolot
Copy link
Owner

I've downloaded cmake version 3.24.3 and tested the fix. Let me know if you have any additional concerns with regard to CMake. To apply the fix immediately to your project:

FetchContent_Declare(
  datatype99
  GIT_REPOSITORY https://github.com/Hirrolot/datatype99
  GIT_TAG aa24712)

hirrolot added a commit to hirrolot/interface99 that referenced this issue Nov 15, 2022
hirrolot added a commit to hirrolot/metalang99 that referenced this issue Nov 15, 2022
hirrolot added a commit to hirrolot/slice99 that referenced this issue Nov 15, 2022
hirrolot added a commit to OpenIPC/smolrtsp that referenced this issue Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants