You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this PR, null is being added as a valid modelValue type to all controls.
Before it needed to be either the type that is reasonable for the control in question (eg. string for HstText), or undefined. However, authors of components (for which they are writing stories) might choose to allow null as a value for their props.
Controls should not have much opinion about how authors choose to type their components, but instead make it easy and seamless to write stories.
Let me know if you have any questions or disagree 😊
What is the purpose of this pull request?
Bug fix
New Feature
Documentation update
Other
type adjustment
Before submitting the PR, please make sure you do the following
If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With this PR,
null
is being added as a validmodelValue
type to all controls.Before it needed to be either the type that is reasonable for the control in question (eg.
string
forHstText
), orundefined
. However, authors of components (for which they are writing stories) might choose to allownull
as a value for their props.Controls should not have much opinion about how authors choose to type their components, but instead make it easy and seamless to write stories.
Let me know if you have any questions or disagree 😊
What is the purpose of this pull request?
type adjustment
Before submitting the PR, please make sure you do the following
fixes #123
).