Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs features #49

Merged
merged 5 commits into from
Mar 15, 2022
Merged

Docs features #49

merged 5 commits into from
Mar 15, 2022

Conversation

topenkoff
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #49 (b9c5569) into master (c3eea33) will increase coverage by 3.41%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   71.00%   74.42%   +3.41%     
==========================================
  Files          41       41              
  Lines         714      696      -18     
==========================================
+ Hits          507      518      +11     
+ Misses        207      178      -29     
Impacted Files Coverage Δ
hitbox/src/cache.rs 80.00% <ø> (ø)
hitbox/src/response.rs 84.61% <ø> (ø)
hitbox-actix/src/actor.rs 80.00% <0.00%> (-10.00%) ⬇️
hitbox/src/value.rs 60.00% <0.00%> (-3.34%) ⬇️
hitbox-actix/src/messages.rs 88.88% <0.00%> (-2.03%) ⬇️
hitbox/src/states/upstream_polled/successful.rs 40.74% <0.00%> (-0.93%) ⬇️
hitbox-derive/src/macro_attributes.rs 0.00% <0.00%> (ø)
hitbox/src/states/cache_polled/error.rs 0.00% <0.00%> (ø)
hitbox/src/states/cache_polled/actual.rs 100.00% <0.00%> (ø)
hitbox/src/states/cache_policy/non_cacheable.rs 100.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3eea33...b9c5569. Read the comment docs.

@topenkoff
Copy link
Member Author

Rust version was increased by several reasons:

  • in 1.52, rustdoc lint was changed and this was required in protobuf(dependency of prometheus)
  • Examples use actix-web=4.0. In actix-web added feature from issue #78835. That feature was added in 1.54

@topenkoff topenkoff marked this pull request as ready for review March 10, 2022 15:41
@singulared singulared merged commit 3fd47de into hit-box:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants