Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define additional disks with defined sizes to VMs for Azure #2953

Merged
merged 5 commits into from
Feb 8, 2022
Merged

Define additional disks with defined sizes to VMs for Azure #2953

merged 5 commits into from
Feb 8, 2022

Conversation

cicharka
Copy link
Contributor

@cicharka cicharka commented Feb 7, 2022 •
edited
Loading

Generic way to add and attach additional disks for VMs.
Additional resource is not placed under azurerm_virtual_machine resource but as separate resource because:

  • it gives opportunity to simplify configuration file (and it also unifies how it is done on AWS)
  • it can be later enhanced to attach already existing disks (not possible if storage disks are attached under azurerm_virtual_machine )

@cicharka cicharka marked this pull request as draft February 7, 2022 08:21
@cicharka cicharka changed the title Additional disks for azure - draft Define additional disks with defined sizes to VMs for Azure Feb 7, 2022
@cicharka cicharka marked this pull request as ready for review February 8, 2022 10:21
@erzetpe erzetpe merged commit bb52839 into hitachienergy:feature/rook-ceph-storage Feb 8, 2022
@cicharka cicharka linked an issue Feb 8, 2022 that may be closed by this pull request
[FEATURE REQUEST] Define additional disks with defined sizes to VMs for Azure #2888
Closed
13 tasks
erzetpe added a commit to erzetpe/epiphany that referenced this pull request Feb 9, 2022
@erzetpe
Define additional disks with defined sizes to VMs for Azure (hitachie…
92ce2c3 
…nergy#2953)

* Additional disks for azure DRAFT

* Simplify config

* add changelog note

* Change starting index value in names

* Change value of lun attribute to alling with disks indexing
erzetpe added a commit that referenced this pull request Feb 9, 2022
@erzetpe
Define additional disks with defined sizes to VMs for Azure (#2953)
b865ddc 
* Additional disks for azure DRAFT

* Simplify config

* add changelog note

* Change starting index value in names

* Change value of lun attribute to alling with disks indexing
erzetpe added a commit to erzetpe/epiphany that referenced this pull request Feb 24, 2022
@erzetpe
Define additional disks with defined sizes to VMs for Azure (hitachie…
50c412f 
…nergy#2953)

* Additional disks for azure DRAFT

* Simplify config

* add changelog note

* Change starting index value in names

* Change value of lun attribute to alling with disks indexing
erzetpe added a commit to erzetpe/epiphany that referenced this pull request Feb 24, 2022
@erzetpe
Define additional disks with defined sizes to VMs for Azure (hitachie…
b290b69 
…nergy#2953)

* Additional disks for azure DRAFT

* Simplify config

* add changelog note

* Change starting index value in names

* Change value of lun attribute to alling with disks indexing
erzetpe added a commit that referenced this pull request Feb 24, 2022
@erzetpe
Define additional disks with defined sizes to VMs for Azure (#2953)
81e9550 
* Additional disks for azure DRAFT

* Simplify config

* add changelog note

* Change starting index value in names

* Change value of lun attribute to alling with disks indexing
erzetpe added a commit that referenced this pull request Mar 1, 2022
@erzetpe
Define additional disks with defined sizes to VMs for Azure (#2953)
2b3aafb 
* Additional disks for azure DRAFT

* Simplify config

* add changelog note

* Change starting index value in names

* Change value of lun attribute to alling with disks indexing
erzetpe added a commit that referenced this pull request Mar 3, 2022
@erzetpe
Define additional disks with defined sizes to VMs for Azure (#2953)
accc892 
* Additional disks for azure DRAFT

* Simplify config

* add changelog note

* Change starting index value in names

* Change value of lun attribute to alling with disks indexing
erzetpe added a commit that referenced this pull request Mar 8, 2022
@erzetpe
Define additional disks with defined sizes to VMs for Azure (#2953)
37f7b1b 
* Additional disks for azure DRAFT

* Simplify config

* add changelog note

* Change starting index value in names

* Change value of lun attribute to alling with disks indexing
erzetpe added a commit that referenced this pull request Mar 22, 2022
@erzetpe
Define additional disks with defined sizes to VMs for Azure (#2953)
4d9ec61 
* Additional disks for azure DRAFT

* Simplify config

* add changelog note

* Change starting index value in names

* Change value of lun attribute to alling with disks indexing
erzetpe added a commit that referenced this pull request Apr 4, 2022
@erzetpe
Define additional disks with defined sizes to VMs for Azure (#2953)
91aca7b 
* Additional disks for azure DRAFT

* Simplify config

* add changelog note

* Change starting index value in names

* Change value of lun attribute to alling with disks indexing
cicharka pushed a commit to cicharka/epiphany that referenced this pull request Apr 11, 2022
@erzetpe @cicharka
Define additional disks with defined sizes to VMs for Azure (hitachie…
7738653 
…nergy#2953)

* Additional disks for azure

* Simplify config

* add changelog note

* Change starting index value in names

* Change value of lun attribute to alling with disks indexing
cicharka pushed a commit to cicharka/epiphany that referenced this pull request Apr 11, 2022
@erzetpe @cicharka
Define additional disks with defined sizes to VMs for Azure (hitachie…
e4885a4 
…nergy#2953)

* Additional disks for azure

* Simplify config

* add changelog note

* Change starting index value in names

* Change value of lun attribute to alling with disks indexing
cicharka pushed a commit to cicharka/epiphany that referenced this pull request Apr 11, 2022
@erzetpe @cicharka
Define additional disks with defined sizes to VMs for Azure (hitachie…
1b1031b 
…nergy#2953)

* Additional disks for azure

* Simplify config

* add changelog note

* Change starting index value in names

* Change value of lun attribute to alling with disks indexing
cicharka pushed a commit to cicharka/epiphany that referenced this pull request Apr 11, 2022
@erzetpe @cicharka
Define additional disks with defined sizes to VMs for Azure (hitachie…
bbd9830 
…nergy#2953)

* Additional disks for azure DRAFT

* Simplify config

* add changelog note

* Change starting index value in names

* Change value of lun attribute to alling with disks indexing
cicharka pushed a commit to cicharka/epiphany that referenced this pull request Apr 11, 2022
@erzetpe @cicharka
Define additional disks with defined sizes to VMs for Azure (hitachie…
392c87e 
…nergy#2953)

* Additional disks for azure DRAFT

* Simplify config

* add changelog note

* Change starting index value in names

* Change value of lun attribute to alling with disks indexing
cicharka pushed a commit that referenced this pull request Apr 11, 2022
@erzetpe @cicharka
Define additional disks with defined sizes to VMs for Azure (#2953)
30d8659 
* Additional disks for azure DRAFT

* Simplify config

* add changelog note

* Change starting index value in names

* Change value of lun attribute to alling with disks indexing
erzetpe added a commit that referenced this pull request Apr 20, 2022
@erzetpe @atsikham
@plirglo @to-bar @seriva @cicharka @przemyslavic
Feature Rook/Ceph storage (#3002)
bf36a7f 
* Define additional disks with defined sizes to VMs for Azure (#2953)

* Additional disks for azure DRAFT

* Simplify config

* add changelog note

* Change starting index value in names

* Change value of lun attribute to alling with disks indexing

* Merge 'develop' into 'feature/rook-ceph-storage' (#2959)

* K8s improvements (#2918)

* Removal of Logstash component - next steps #2833 (#2941)

* Add information about manual package removal that
  needs to be performed by cluster admin
* include information about inventory file

* Fix for ansible_default_ipv4 empty value (#2922)

* Fix for ansible_default_ipv4 empty value

* Fix after ToBar review

* Add check if there is only one default routing config

* Add check for different metrics value in case more than one default routing

* Review fixes

* Update fail_msg

Co-authored-by: to-bar <46519524+to-bar@users.noreply.github.com>

* Extend k8s schema validation (#2929)

* Extend deprecation note with Ignite removal steps (#2949)

* Escalate permissions for ip command (#2952)

* Changed autoscaling_group to plain EC2 VMs on AWS. (#2939)

- Replaced AWS auto_scaling_groups with plain EC2 VM creation.
- Added proper host sorting how it was implemented for the any and azure providers: #1076
- Sync up features with Azure Terraform implementation
-  Added support for use_network_security_groups flag #959
- Updated DoD for bugs to reflect changes made for #2832

Co-authored-by: Anatoli Tsikhamirau <anatoliytihomirov@yahoo.com>
Co-authored-by: Irek Głownia <48471627+plirglo@users.noreply.github.com>
Co-authored-by: to-bar <46519524+to-bar@users.noreply.github.com>
Co-authored-by: Luuk van Venrooij <11056665+seriva@users.noreply.github.com>

* Add Ansible Rook role (#2960)

* Add initial ansible rook role

* Fix issue with no yet existing template

* Add Rook schema related files

* Remove already setup vars, add missing enters

* Fix issue with feature mapping

* Add configuration support

* Move kubeconfig to rook role yaml

* Update changelog

* Add started dashes to yaml defaults for Rook

* Add RH fix suggested by cicharka

* Add rook cluster helm chart installation

* Add separate chart values definitions

* Limit fact checking in rook role

* Add initial rook/ceph documentation

* Update documentation for Rook

* Update download requirements

* Persistent Storage: Note about disks on AWS (#2998)

* Updated changelog

* Rearrange and update documentation

* Update components

* Fix after review

* Limit hosts where apply is specified

* Add comment about repository facts gathering

* Make rook namespace configurable

* Add linter comments to disable false positive

* Add requested comments

* Change shell to command module

* Change mode to preserve for temp configuration data

* Update documentation

* Update ansible/playbooks/roles/repository/files/download-requirements/requirements/x86_64/images.yml

Co-authored-by: przemyslavic <43173646+przemyslavic@users.noreply.github.com>

* Update ansible/playbooks/roles/repository/files/download-requirements/requirements/x86_64/images.yml

Co-authored-by: przemyslavic <43173646+przemyslavic@users.noreply.github.com>

* Update ansible/playbooks/roles/repository/files/download-requirements/requirements/x86_64/images.yml

Co-authored-by: przemyslavic <43173646+przemyslavic@users.noreply.github.com>

* Update ansible/playbooks/roles/repository/files/download-requirements/requirements/x86_64/images.yml

Co-authored-by: przemyslavic <43173646+przemyslavic@users.noreply.github.com>

* Update ansible/playbooks/roles/repository/files/download-requirements/requirements/x86_64/images.yml

Co-authored-by: przemyslavic <43173646+przemyslavic@users.noreply.github.com>

* Update ansible/playbooks/roles/repository/files/download-requirements/requirements/x86_64/images.yml

Co-authored-by: przemyslavic <43173646+przemyslavic@users.noreply.github.com>

* Update ansible/playbooks/roles/repository/files/download-requirements/requirements/x86_64/images.yml

Co-authored-by: przemyslavic <43173646+przemyslavic@users.noreply.github.com>

* Update ansible/playbooks/roles/repository/files/download-requirements/requirements/x86_64/images.yml

Co-authored-by: przemyslavic <43173646+przemyslavic@users.noreply.github.com>

* use newer version of rook (#3053)

* Feature/rook ceph storage additions (#3064)

* rook/ceph: add default values in epiphany configuration

* rook/ceph (#3068)

* add default values in epiphany configuration
* bump up verison of rook

* Revert schema defaults (#3074)

* Revert "rook/ceph (#3068)"

This reverts commit 989be85.

* Revert "Feature/rook ceph storage additions (#3064)"

This reverts commit 17c49af.

* minor fixes for schema and docs

* add rook feature_mapping for single and custom

* rook: modify tests and schema for image registry

* rook: offline mode

* enahnce playbook to allow chart files use images from
  local image registry
* remove unused condition for chart and operator specification
  which is always defined now
* modify path for rook/ceph image in order to be compliant
  with values.yml

Signed-off-by: cicharka <arkadiusz.cichon@outlook.com>

* rook: add missing csiaddons for offline mode

Signed-off-by: cicharka <arkadiusz.cichon@outlook.com>

Co-authored-by: Anatoli Tsikhamirau <anatoliytihomirov@yahoo.com>
Co-authored-by: Irek Głownia <48471627+plirglo@users.noreply.github.com>
Co-authored-by: to-bar <46519524+to-bar@users.noreply.github.com>
Co-authored-by: Luuk van Venrooij <11056665+seriva@users.noreply.github.com>
Co-authored-by: cicharka <93913624+cicharka@users.noreply.github.com>
Co-authored-by: przemyslavic <43173646+przemyslavic@users.noreply.github.com>
Co-authored-by: cicharka <arkadiusz.cichon@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seriva seriva seriva left review comments

@erzetpe erzetpe erzetpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Define additional disks with defined sizes to VMs for Azure
3 participants
@cicharka @erzetpe @seriva