Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: question disclosure validation and translation #2877

Merged
merged 12 commits into from
Sep 30, 2024

Conversation

diegosteiner
Copy link
Contributor

Fixes #2876

@diegosteiner diegosteiner requested a review from kronn September 23, 2024 13:55
@diegosteiner diegosteiner marked this pull request as ready for review September 23, 2024 13:56
@diegosteiner diegosteiner force-pushed the feature/hitobito_youth#58 branch from 8c9b080 to 6ecd5a3 Compare September 23, 2024 14:22
Copy link
Member

@kronn kronn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nur eine Frage.

app/models/event/question.rb Show resolved Hide resolved
@diegosteiner diegosteiner self-assigned this Sep 25, 2024
@diegosteiner diegosteiner force-pushed the feature/hitobito_youth#58 branch from b8c0a4c to ddd0224 Compare September 25, 2024 12:20
spec/models/event/question_spec.rb Show resolved Hide resolved
@diegosteiner
Copy link
Contributor Author

@kronn darf ich dich nochmals für ein Codereview bemühen, bitte?

@diegosteiner diegosteiner merged commit 53bcdae into master Sep 30, 2024
7 checks passed
@diegosteiner diegosteiner deleted the feature/hitobito_youth#58 branch September 30, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anlass erstellen: Komisches Verhalten mit Pflichtfeld AHV-Nummer
2 participants