Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wording to use shipp tool and turn download on by default #947

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

r-ash
Copy link
Collaborator

@r-ash r-ash commented Mar 19, 2024

Description

This PR updates wording for SHIPP tool (was previously called AGYW) and enables it by default. Leaving the feature switch in for the time being just in case any issues and we want to turn it off again.

Note this doesn't work with Malawi test data because IDs in test data have been modified from their real ID.

This is in draft until we get the go ahead from science to deploy this.

Type of version change

Patches

Checklist

  • I have incremented version number, or version needs no increment
  • The build passed successfully, or failed because of ADR tests

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99%. Comparing base (f46238a) to head (14bbd7f).

Additional details and impacted files
@@           Coverage Diff            @@
##             master    #947   +/-   ##
========================================
  Coverage        99%     99%           
  Complexity      422     422           
========================================
  Files           248     248           
  Lines         20570   20570           
  Branches       2294    2291    -3     
========================================
  Hits          20400   20400           
  Misses          128     128           
  Partials         42      42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r-ash r-ash marked this pull request as draft March 20, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant