Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authentication does not work with encoded URIs with special chars #12

Closed
hunkoi opened this issue Aug 11, 2022 · 1 comment
Closed

Authentication does not work with encoded URIs with special chars #12

hunkoi opened this issue Aug 11, 2022 · 1 comment

Comments

@hunkoi
Copy link
Contributor

hunkoi commented Aug 11, 2022

Example:

api/v1/apps/QA-Stable%2B1
which was originally api/v1/apps/QA-Stable+1

Client MAC is generated using URI(decoded or encoded as client decides) and then we have to do the same on our side. The problem is that our library always generate MAC with decoded URL.
@hunkoi hunkoi changed the title Authentication does not work with encoded URIs Authentication does not work with encoded URIs with special chars Aug 11, 2022
hunkoi added a commit to hunkoi/hawk that referenced this issue Aug 11, 2022
@hunkoi
hiyosi#12 Fix MAC generation for encoded URIs with special chars
af7b0cc
@hunkoi hunkoi mentioned this issue Aug 11, 2022
Merged
@hunkoi
Copy link
Contributor Author

hunkoi commented Aug 11, 2022

Fix is here: #13

@hiyosi please consider merge this bug-fix

hunkoi added a commit to hunkoi/hawk that referenced this issue Aug 11, 2022
@hunkoi
hiyosi#12 Fix MAC generation for encoded URIs with special chars
d4059a9
hunkoi added a commit to hunkoi/hawk that referenced this issue Aug 11, 2022
@hunkoi
hiyosi#12 Fix MAC generation for encoded URIs with special chars
d32afe5
hiyosi pushed a commit that referenced this issue Aug 12, 2022
Merge pull request #13 from hunkoi/h/12
7eb7975 
#12 Fix MAC generation for encoded URIs with special chars
@hiyosi hiyosi closed this as completed Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hiyosi @hunkoi