Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phi-3-small issues #5475

Merged
merged 4 commits into from
Nov 2, 2024
Merged

Fix phi-3-small issues #5475

merged 4 commits into from
Nov 2, 2024

Conversation

menibrief
Copy link
Contributor

@menibrief menibrief commented Sep 18, 2024

What does this PR do?

Fixes phi-3-small template that is currently broken

Fixes #4712
Fixes #3881

Before submitting

update readme to phi-small template
@menibrief
Copy link
Contributor Author

@hiyouga Did you see an issue with this? Not sure why this simple bug fix isn't 'pending' yet.

Copy link
Owner

@hiyouga hiyouga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiyouga hiyouga merged commit 9a42c5f into hiyouga:main Nov 2, 2024
12 checks passed
1587causalai pushed a commit to 1587causalai/llama_factory that referenced this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phi-3-small Different Chat Template Phi-3-small exploding gradient issue.
2 participants