Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Classifying geometry based on RMSD #213
Classifying geometry based on RMSD #213
Changes from 7 commits
6601dc5
bfef0d5
b576b86
d36f4c7
6395133
391d51c
51dd7b7
79272c1
5f49ace
46abd16
60122e1
9378d27
ae35599
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testing this function, it seems that it could be replaced by
itertools.permutations()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which I have done in my recent changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that
get_first_shell
is limited to a maximum coordination number of 6: it uses the functionobtain_truncation_metal
to get the first shell (before applying any edge/sandwich logic), which determines neighbors using thegetBondedAtomsSmart
function. This function, as shown in commit 79272c1, assumes a maximum coordination number of 6. If the default behavior ofgetBondedAtomsSmart
is set to not assume a maximum of 6-coordinated structures, some of the tests will fail for geometry checks, so I do not want to change that behavior. However, changing theoct
argument toFalse
will allow forget_geometry_type_distance
to classify geometries with coordination numbers higher than 6, which I have tested. I can introduce a workaround variable to allow for different behavior (such as in commit 46abd16), but I do not want to add that argument to more functions than needed (since readability on those extra arguments would be difficult to interpret). I would argue that we should change the test cases to addoct=True
togetBondedAtomsSmart
(since that function should not assume a maximum coordination number), but I am not sure if that would also require adding arguments to many functions to ensure that the test cases work as intended.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just spent some time trying to understand why these 4 test cases:
test_geocheck_oct[broken_ligands]
test_geocheck_oct[H_transfer]
test_geocheck_oct[rotational_group]
test_geocheck_oct[iodine_sulfur]
fail when we set
oct=False
as default ingetBondedAtomsSmart
and got nowhere... My recommendation for now is just to merge what you have and address this issue during the hackathon on higher coordination complexes.