pool: load missing prerequisite status from database #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Accompanies cylc#5334 which fixes traceback for missing prereqs on reload/restart by marking them as unsatisfied.
oliver-sanders
commented
Mar 1, 2023
| if do_restart: | ||
| async with start(schd): | ||
| # start the workflow and run part 1 of the tests | ||
| test.asend(schd) |
There was a problem hiding this comment.
Generators can yield data, but you can also send data into them with generator.send.
asend is the async version of send for async generators.
This is a sneaky trick to avoid having to write the same test twice once for reload and once for restart.
8 tasks
|
(Questions addressed on main PR page) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a prerequisite is missing from the database on reload/restart, then look through the task outputs table to see whether it is satisfied.
Two issues/questions:
satisfied naturally. I think the information is lost by this point, is there a more suitable value e.gsatisfied from DB?