Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes name property in output when no challenge is sent #53

Merged
merged 1 commit into from
May 14, 2022

Conversation

ThePoShWolf
Copy link
Contributor

PR Summary

As referenced in #51, this fixes the issue that causes server names to lose their first character in the output.

This was tested using your Windows server IP from #51 and my Linux server.

Context

Since line 85 was moving the stream's read position, it needs to be moved back for when the output object is built. So an else was added.

Changes

Here is the added code:

if ($Stream.ReadByte() -eq 65) {
    ...
} else {
    $Stream.BaseStream.Position = 0
}

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants