Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework Resolve-VanityURL #71

Merged
merged 13 commits into from
Apr 18, 2024
Merged

Rework Resolve-VanityURL #71

merged 13 commits into from
Apr 18, 2024

Conversation

hjorslev
Copy link
Owner

@hjorslev hjorslev commented Mar 23, 2024 •
edited
Loading

Description

Resolves #70

  • Remove OutputFormat parameter
  • Accept multiple inputs with the VanityURL parameter
  • Change to non terminating error
  • Output content as PSCustomObject

Type of change

  • 📖 [Docs]
  • 🪲 [Fix]
  • 🩹 [Patch]
  • ⚠️ [Security fix]
  • 🚀 [Feature]
  • 🌟 [Breaking change]

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added Pester tests that covers the added cmdlets

@hjorslev hjorslev added Category-Module Pertaining to the module's functionality itself. Issue-Bug 🐛 Something's wrong! Issue-Enhancement ✨ Make it better! labels Mar 23, 2024
@hjorslev hjorslev self-assigned this Mar 23, 2024
@hjorslev hjorslev linked an issue Mar 23, 2024 that may be closed by this pull request
Remove OutputFormat parameter from Resolve-VanityURL #70
Closed
@hjorslev hjorslev mentioned this pull request Apr 1, 2024
Closed
@hjorslev hjorslev changed the title Refactor Resolve-VanityURL Rework Resolve-VanityURL Apr 14, 2024
@hjorslev hjorslev linked an issue Apr 16, 2024 that may be closed by this pull request
Pester Tests for Web API cmdlets #31
Closed
@hjorslev hjorslev merged commit 7806f93 into master Apr 18, 2024
9 checks passed
@hjorslev hjorslev deleted the 70-remove-outputformat-parameter-from-resolve-vanityurl branch April 18, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hjorslev hjorslev

Labels
Breaking 🌟 Category-Module Pertaining to the module's functionality itself. Issue-Bug 🐛 Something's wrong! Issue-Enhancement ✨ Make it better!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove OutputFormat parameter from Resolve-VanityURL Pester Tests for Web API cmdlets
1 participant
@hjorslev