Fix for PHP8.2 deprecation - property must be defined in class, not dynamically #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks to @theodoreslechta for identifying this issue via another project. |
peter279k
approved these changes
Sep 12, 2023
|
@chrisputnam9 thanks for fixing! The automatic tests have stalled because there are no longer any runners for Ubuntu 18. I've fixed that and added PHP 8.2 and PHP 8.3 in #37. |
trobro
force-pushed
the
feature-php-8.2-fix
branch
from
d6e2a87
to
9b7d013
Compare
|
Thanks @trobro & @peter279k ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set private $meta in class definition to avoid deprecation warning about dynamically set property.