-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] migrate code from ros1 to ros2 #131
base: main
Are you sure you want to change the base?
Conversation
@sujit-168 I have added a couple of new commits to your work, so that the parameters are set on the main node properly: Also, your version of Vikit isn't public, so the version I have compiled against is here: https://github.com/integralrobotics/rpg_vikit.git I was thinking about modernising the |
@james-ward Thank you for contributing to this pull request, especially for open-sourcing your completely modified solution. Your modifications to Vikit are another interesting approach. |
I have put in a PR to your original branch: Robotic-Developer-Road#1 |
@james-ward Regarding the way to read camera parameters, my suggestion is to keep two solutions so that the community can refer to them. This issue can have more discussions. |
Sure. But until you release the version of Vikit you are using I couldn't get your method to work. |
45a4942
to
137b660
Compare
The key migration part occurs in the following commits, other commits are about minor changes.