Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] migrate code from ros1 to ros2 #131

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

sujit-168
Copy link

@sujit-168 sujit-168 commented Mar 3, 2025

@james-ward
Copy link

@sujit-168 I have added a couple of new commits to your work, so that the parameters are set on the main node properly:
https://github.com/integralrobotics/FAST-LIVO2

Also, your version of Vikit isn't public, so the version I have compiled against is here: https://github.com/integralrobotics/rpg_vikit.git

I was thinking about modernising the CMakeLists.txt file to use a cleaner approach, if you are interested in that as well.

@sujit-168
Copy link
Author

@james-ward Thank you for contributing to this pull request, especially for open-sourcing your completely modified solution. Your modifications to Vikit are another interesting approach.

@james-ward
Copy link

I have put in a PR to your original branch: Robotic-Developer-Road#1

@sujit-168
Copy link
Author

@james-ward Regarding the way to read camera parameters, my suggestion is to keep two solutions so that the community can refer to them. This issue can have more discussions.

@james-ward
Copy link

@james-ward Regarding the way to read camera parameters, my suggestion is to keep two solutions so that the community can refer to them. This issue can have more discussions.

Sure. But until you release the version of Vikit you are using I couldn't get your method to work.

@xuankuzcr xuankuzcr force-pushed the main branch 2 times, most recently from 45a4942 to 137b660 Compare March 29, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants