Elasticsearch 8.0 support

[hkulekci]

Here the list of changes :

Aggregation

• Percentiles aggregation: disallow specifying same percentile values twice #52257 (issue: #51871)
• Remove Adjacency_matrix setting #46327 (issues: #46257, #46324)
• Remove MovingAverage pipeline aggregation #39328
• Remove deprecated _time and _term sort orders #39450
• Remove deprecated date histo interval #75000

Geo

• Disallow creating geo_shape mappings with deprecated parameters #70850 (issue: #32039)
• Remove bounding box query type parameter #74536

Infra REST API

• Remove content type required setting #61043
• Allow parsing Content-Type and Accept headers with version #61427

Search

• Fix range query on date fields for number inputs #63692 (issue: #63680)
• Parse empty first line in msearch request body as action metadata #41011 (issue: #39841)
• Remove CommonTermsQuery and cutoff_frequency param #42654 (issue: #37096)
• Remove type query #47207 (issue: #41059)
• Remove use_field_mapping format option for docvalue fields #55622
• Remove deprecated SimpleQueryStringBuilder parameters #57200
• Remove deprecated search.remote settings #42381 (issues: #33413, #38556)
• Remove deprecated sort options: nested_path and nested_filter #42809 (issue: #27098)
• Remove deprecated vector functions #48725 (issue: #48604)
• Remove support for _type in searches #68564 (issues: #41059, [#68311]
• Remove support for sparse vectors #48781 (issue: #48368)
  ([Fields API] _type is not returned in the response elastic/elasticsearch#68311))
• Remove the object format for indices_boost #55078
• Removes typed endpoint from search and related APIs #41640
• Removes type from TermVectors APIs #42198 (issue: #41059)

[matchish]

I see that phpunit have to be updated. Code coverage not supported with php8 by this version

[hkulekci]

👍 Let me check it

[hkulekci]

Interestingly, tests passed for both versions as I tried locally. For now, with PHP 8.0.9, I tried PHPUnit 9.5.13 and 8.5.23 with coverage flag and both are working without any error.

[matchish]

Looks great to me)

[hkulekci]

I could not understand what I need to do related withindices_boost parameter. I think, no need to do any changes.

[matchish]

Could you point where described breaking changes in es8 for this parameter?

[hkulekci]

Could you point where described breaking changes in es8 for this parameter?

Inside the search part :

• Remove the object format for indices_boost #55078

https://www.elastic.co/guide/en/elasticsearch/reference/master/release-notes-8.0.0.html

[hkulekci]

I think we don't do anything. I will try to put a functional test for it. There is a parameter inside the Search class of this library, but we do not try to format the parameter's value. So, I think it is not this library's responsibility.

[matchish]

Yeah you're right. We don't check format of indices boosts so no changes.

[matchish]

We could introduce interface for the parameter, but looks it's not the way of this library

[hkulekci]

Okay, here is the latest situation. I fetched the list from the release notes of the Elasticsearch page, and I checked the bullets one by one. I close some of them directly without changing the code because of their disinterests. Lastly, we have one issue now is related to sorting with nested fields.

Remove deprecated sort options: nested_path and nested_filter elastic/elasticsearch#42809 (issue: elastic/elasticsearch#27098)

I had not used it before. For this reason, I will investigate a little bit what the changes are. Then we can go through the PR to the main repository.

Thanks.

[hkulekci]

Okay so, as I see, nested-related deprecation changes are already done at 7.x version.
https://github.com/ongr-io/ElasticsearchDSL/pull/267/files

[hkulekci]

Before :

POST /_search
{
   "query" : {
      "term" : { "product" : "chocolate" }
   },
   "sort" : [
       {
          "offer.price" : {
             "mode" :  "avg",
             "order" : "asc",
             "nested_path" : "offer",
             "nested_filter" : {
                "term" : { "offer.color" : "blue" }
             }
          }
       }
    ]
}

After :

POST /_search
{
   "query" : {
      "term" : { "product" : "chocolate" }
   },
   "sort" : [
       {
          "offer.price" : {
             "mode" :  "avg",
             "order" : "asc",
             "nested": {
                "path": "offer",
                "filter": {
                   "term" : { "offer.color" : "blue" }
                }
             }
          }
       }
    ]
}