Sync IR changes

[waterlens]

No description provided.

[LPTK]

If the compiler project's tests now need to run only from the nix command (which I don't like), you should change the build.sbt so compilerJVM is not part of the .aggregate root project.

But I don't like this very much. Can't we just run something like "nix install" and then make sure the correct tools are used when calling them from SBT?

[waterlens]

If the compiler project's tests now need to run only from the nix command (which I don't like), you should change the build.sbt so compilerJVM is not part of the .aggregate root project.

But I don't like this very much. Can't we just run something like "nix install" and then make sure the correct tools are used when calling them from SBT?

I think Nix never changes things outside the environment, rather they have overlays where you have your settings and then offer you commands to go inside to use it.

It could be quite slow to invoke nix like using make in DiffTests, because we need to do that for every single runCpp test. If we want that, it would also require us to write the intermediate cpp code into a file in the source tree, otherwise, I don't know how to put it into the nix env ...

[pca006132]

You can treat nix develop as setting up a docker/vm, and it has the environment variables set inside it.

Technically you can install things globally, but it is not idiomatic and kind of violates the nix philosophy.

[LPTK]

@pca006132 Could you please describe the full solution that using nix develop implies?

1. What are the commands, if any, that the CI and local users need to run in order to install the tools? (Of course, no global installs!)
2. What are the commands that the SBT process is supposed to shell out in order to run the C++ compiler?

[LPTK]

It's probably fine if we have to use the SBT command from some sort of special command like <setup nix env> sbt test

[pca006132]

CI: nix develop --command sbt compilerJVM/test.

Local user:

# enter shell
nix develop
# inside the shell...
sbt compilerJVM/test

I typically use direnv. If you use it with the file .envrc with use_flake in the directory, you can just enter the directory and just run sbt compilerJVM/test, the environment is automatically setup when you enter the directory and destroyed when you exit.

[LPTK]

@pca006132 Thanks!

@waterlens Does this work for you?

[waterlens]

@pca006132 Thanks!

@waterlens Does this work for you?

I think I have used it in the CI. So, what's the next step? Moving compilerJVM out of the root target?

[LPTK]

I just checked the CI config. I don't understand why you used nix develop --command sbt compilerJVM/test instead of running everything under the nix environment as nix develop --command sbt test (replacing the old test command).

[waterlens]

I once thought it was only used to set up the environment for testing cpp backend. Anyway, if you accept the idea to test the whole project in a nix environment, I will change it accordingly.

[LPTK]

Yeah, there's no reason not to place the whole thing under nix. It would also be useful to fix the nodejs version while we're at it!

[waterlens]

As far as I know, nixpkgs only support LTS version NodeJS. Can we upgrade the version from 17 to 18? Otherwise, I may need to install NodeJs from the tarball.

[LPTK]

Ok I managed to fix the CI and to make the tests pass on my older local macOS version by switching to g++!