Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BFS Number eCH-0011: Extension to define a BFS Number for a municipality or a country #45

Closed
oliveregger opened this issue Mar 8, 2020 · 8 comments
Labels
STU 0.1.0 Ballot Comments/Issues from the Ballot for STU1

Comments

@oliveregger
Copy link
Contributor

Paul Bernet:

Attribute name "ECH011BFSNumber" may not be a suitable name for this extension:
http://fhir.ch/ig/ch-core/StructureDefinition-ch-ext-ech-11-bfsnumber.html
because it is applied to:
{"type"=>"Address.city"} //Semantic OK
{"type"=>"Address.country"} //Semantic NOK, because a country, where a person was born, does not have a BFS Number

Suggestion:
Only use extension for "Address.city" OR change the name of the attribute to include both cases

@oliveregger oliveregger added the STU 0.1.0 Ballot Comments/Issues from the Ballot for STU1 label Mar 8, 2020
@oliveregger
Copy link
Contributor Author

Dmytro Rud: In StructureDefinition-ch-ext-ech-11-bfsnumberl: Für Länder kann es keine BFS-Nr. geben.

@oliveregger
Copy link
Contributor Author

@oliveregger
Copy link
Contributor Author

variante 1: bfs nummer nicht als extension verwenden
variante 2: bfs nummer ech 72 definieren
variante 3: country code 2 stellig als extension falls es zweistellig ist, sonst dreistellig (äquivalent IPS)
variante 4: variante 2 + 3 zusammen

Vorschlag Variante 3: 9 - 0 - 0

@oliveregger
Copy link
Contributor Author

@oliveregger
Copy link
Contributor Author

@oliveregger
Copy link
Contributor Author

adapted also ch-core-address-ech-11-placeofbirth and ch-core-address-ech-11-placeoforigin for that

@oliveregger
Copy link
Contributor Author

adapted ch-ext-exch11-bfsnumber that is only for a municipalityId (city) according to ech-11 resp ech-7 and renamed extension

@oliveregger oliveregger added this to the STU1 milestone Mar 18, 2020
oliveregger added a commit that referenced this issue Mar 19, 2020
oliveregger added a commit that referenced this issue Mar 19, 2020
@oliveregger
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
STU 0.1.0 Ballot Comments/Issues from the Ballot for STU1
Projects
None yet
Development

No branches or pull requests

1 participant