Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evil-mulitedit broken with recent iedit changes #39

Closed
CeleritasCelery opened this issue Sep 12, 2020 · 10 comments
Closed

evil-mulitedit broken with recent iedit changes #39

CeleritasCelery opened this issue Sep 12, 2020 · 10 comments
Labels
bug

Comments

@CeleritasCelery
Copy link

A recent commit to iedit breaks evil-multiedit--substitute and evil-multiedit--paste-replace. I was able to bisect the offending commit down to victorhge/iedit@be44da7. It is a pretty large commit so I was not able to find out what actually causes the regression.
@CeleritasCelery
Copy link
Author

FYI @victorhge

@hlissner
Copy link
Owner

This is a known issue that I am working on a fix for. For the time being I've pinned iedit to 77eb0a1e2e44b453e4ebf4c38409affa353f5139 in Doom Emacs. If you aren't using Doom you'll have to do similar for now.

@hlissner hlissner added the bug label Sep 12, 2020
@ema2159
Copy link

ema2159 commented Oct 5, 2020

Is this what's causing this behavior?:

ezgif-6-b07b6f1e9648

@hlissner
Copy link
Owner

hlissner commented Oct 5, 2020

@ema2159 Yes

@hlissner hlissner mentioned this issue Oct 21, 2020
Closed
meqif added a commit to meqif/.emacs.d that referenced this issue Oct 31, 2020
@meqif
Roll iedit back to an unbroken version
7834201 
evil-multiedit is broken since iedit@be44da7

hlissner/evil-multiedit#39
@lccambiaghi lccambiaghi mentioned this issue Dec 7, 2020
Closed
@srnnkls
Copy link

srnnkls commented Jun 9, 2021

Any news on this?

@robbert-vdh robbert-vdh mentioned this issue Jun 13, 2021
Open
@ericdallo
Copy link

lsp-mode introduced a new feature using iedit and some functions that are not available on older iedit versions :/
It'd be really cool fix this issue to bump iedit on doom-emacs

@ericdallo
Copy link

c/c @hlissner

@ericdallo ericdallo mentioned this issue Oct 23, 2021
Merged
hlissner added a commit that referenced this issue Oct 23, 2021
@hlissner
refactor!: use minor mode instead of evil state
36904ce 
BREAKING CHANGE: this package no longer defines or uses
evil-multiedit-state and evil-multiedit-insert-state. Creating our own
evil states (and for what should be a layer over the vanilla ones) adds
unnecessarily complexity and redundancy. Using a minor mode is much
simpler. Activate evil-multiedit-mode instead.

Ref: #39
@hlissner
Copy link
Owner

hlissner commented Oct 23, 2021 •
edited
Loading

Sorry for the late response. As of a451370 evil-multiedit should work fine with the latest commit of iedit, so I'll consider this issue resolved. Let me know if that isn't the case and I'll reopen it.

@ericdallo Thanks for letting me know! I'll bump Doom's module soon. Also, sorry to spring this on you: 36904ce introduced a breaking change I've been sitting on for some time; lsp-evil-multiedit-highlights and lsp-evil-multiedit-linked-ranges will need to be updated:

-  (evil-multiedit-state))
+  (evil-multiedit-mode +1))

My access to a dev machine is unstable so it'll be a couple days before I can PR it myself, so feel free to snipe it if you'd like.

@ericdallo
Copy link

Great! I'll make the proper changes on lsp-mode, thank you for the huge help on this!

ericdallo added a commit to emacs-lsp/lsp-mode that referenced this issue Oct 23, 2021
@ericdallo
Fix evil-multiedit breaking change https://github.com/hlissner/evil-m…
6157b3d 
…ultiedit/issues/39\#issuecomment-950194708

Discussion on hlissner/evil-multiedit#39
@ericdallo
Copy link

Fixed on lsp-mode

hlissner added a commit to doomemacs/doomemacs that referenced this issue Oct 28, 2021
@hlissner
bump: :editor multiple-cursors
363a031 
gabesoft/evil-mc@f04fb17f35f2 -> gabesoft/evil-mc@246aecc17481
hlissner/evil-multiedit@9f271e0e6048 -> hlissner/evil-multiedit@50179bfb269b
magnars/multiple-cursors.el@616fbdd3696f -> magnars/multiple-cursors.el@588daf8c520f

evil-multiedit is no longer locked to victorhge/iedit@77eb0a1e2e44; its
incompatibilities were resolved upstream (see
hlissner/evil-multiedit#39).

Ref: hlissner/evil-multiedit#39
hlissner added a commit to doomemacs/doomemacs that referenced this issue Oct 28, 2021
@hlissner
bump: :tools lsp debugger
251d2a6 
emacs-lsp/dap-mode@a225e73026f2 -> emacs-lsp/dap-mode@a18f29e3d1a3
emacs-lsp/lsp-mode@237363939b26 -> emacs-lsp/lsp-mode@f72278c660a4

Ref: hlissner/evil-multiedit#39
peterhoeg pushed a commit to peterhoeg/doomemacs that referenced this issue Nov 4, 2021
@hlissner @peterhoeg
bump: :editor multiple-cursors
fe3b08b 
gabesoft/evil-mc@f04fb17f35f2 -> gabesoft/evil-mc@246aecc17481
hlissner/evil-multiedit@9f271e0e6048 -> hlissner/evil-multiedit@50179bfb269b
magnars/multiple-cursors.el@616fbdd3696f -> magnars/multiple-cursors.el@588daf8c520f

evil-multiedit is no longer locked to victorhge/iedit@77eb0a1e2e44; its
incompatibilities were resolved upstream (see
hlissner/evil-multiedit#39).

Ref: hlissner/evil-multiedit#39
peterhoeg pushed a commit to peterhoeg/doomemacs that referenced this issue Nov 4, 2021
@hlissner @peterhoeg
bump: :tools lsp debugger
4dc5135 
emacs-lsp/dap-mode@a225e73026f2 -> emacs-lsp/dap-mode@a18f29e3d1a3
emacs-lsp/lsp-mode@237363939b26 -> emacs-lsp/lsp-mode@f72278c660a4

Ref: hlissner/evil-multiedit#39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@hlissner @ericdallo @CeleritasCelery @ema2159 @srnnkls