feat: add the plugin system to the project #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-subtree-dir: plugins/experimentation git-subtree-split: fc522cd842cb598c31318fdcf3634d6635749e7d
9b5939e chore(doc): Update README.md eafd8d4 fix: initCTInternal was defined twice (#12) d37e945 Comply with Plugin API (#11) fba407f chore(update): update to support latest version of boilerplate (#9) bb1762a fix(docs): integration with Analytics solutions without double tracking of the same events (#10) c146fce feat(omnivore): Add conversion tracking data attribute to tracked elements (#7) git-subtree-dir: plugins/rum-conversion git-subtree-split: 9b5939e3f549b0d262d27ca7133054bf5f0c3cf1
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds the plugin system proposed in adobe/aem-boilerplate#254.
It also updates a few lib-franklin.js methods that were missing, updates the rum conversion plugin instrumentation and adds the experimentation plugin as well.
Test URLs: