Static Footer Redesign #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
|
@amlan18041996 - As discussed, please can you implement the footer like the wesee where we have the component HTML within a fragment (which I have added). |
davenichols-DHLS
changed the title
|
|
|
|
|
amlan18041996
changed the title
amlan18041996
requested review from
mhaack,
amlan18041996,
davenichols-DHLS and
sharanagoudapatil
and removed request for
amlan18041996
…lf thus taking small bundle size for styles.css. Border-color converted to purple-500.
|
|
|
davenichols-DHLS
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
This is perfect, @mhaack - when you are back please can you take a quick look and just confirm if you have any issues with this going forward? Thanks.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #170
Test URLs: