-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
641 product citations embeds #656
Conversation
…o 641-product-citations-embeds
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
await loadScript('https://cdn.bioz.com/assets/jquery-2.2.4.js', attrs); | ||
await loadScript('https://cdn.bioz.com/assets/bioz-w-api-6.0.min.js', attrs); | ||
|
||
const biozDiv = `<div id="bioz-w-pb-3230-bzen-q" href="https://www.bioz.com/" target="_blank" style="font-size: 12px; text-decoration: none; color: rgb(10, 67, 133);"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we build this html using dom-builder like in other blocks? and use tailwind / css for styling?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @duynguyen - I've made the required changes. Please have a look. Thanks.
…o 641-product-citations-embeds
…sites/danaher-ls-aem into 641-product-citations-embeds
@mhaack and @duynguyen - if I check the lighthouse scores on main then I am getting 96 to 99, but this is giving 65 to 77. Could this just be generally, or is this because of the citations code being injected? Could/Should we load it on click or differently? |
@davenichols-DHLS let's merge this PR and open a new issue for LHS improvement. It's because the TBT is quite high, caused by the jquery from bioz. However, it's only affecting the citations tab. |
Excellent, I was thinking the same, I added the other tests and the main pages are great, it's just when loading bioz. I am happy to take this. |
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #641
Test URLs: