Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

641 product citations embeds #656

Merged
merged 13 commits into from
Jan 17, 2024
Merged

Conversation

sharanagoudapatil
Copy link
Collaborator

@sharanagoudapatil sharanagoudapatil commented Jan 12, 2024

Copy link
Contributor

aem-code-sync bot commented Jan 12, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jan 12, 2024

await loadScript('https://cdn.bioz.com/assets/jquery-2.2.4.js', attrs);
await loadScript('https://cdn.bioz.com/assets/bioz-w-api-6.0.min.js', attrs);

const biozDiv = `<div id="bioz-w-pb-3230-bzen-q" href="https://www.bioz.com/" target="_blank" style="font-size: 12px; text-decoration: none; color: rgb(10, 67, 133);">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we build this html using dom-builder like in other blocks? and use tailwind / css for styling?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @duynguyen - I've made the required changes. Please have a look. Thanks.

@aem-code-sync aem-code-sync bot temporarily deployed to 641-product-citations-embeds January 15, 2024 10:44 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 641-product-citations-embeds January 15, 2024 11:11 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 641-product-citations-embeds January 15, 2024 14:19 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 641-product-citations-embeds January 17, 2024 11:40 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 641-product-citations-embeds January 17, 2024 12:32 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 641-product-citations-embeds January 17, 2024 12:52 Inactive
@davenichols-DHLS
Copy link
Collaborator

@mhaack and @duynguyen - if I check the lighthouse scores on main then I am getting 96 to 99, but this is giving 65 to 77. Could this just be generally, or is this because of the citations code being injected? Could/Should we load it on click or differently?

@aem-code-sync aem-code-sync bot temporarily deployed to 641-product-citations-embeds January 17, 2024 13:58 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 641-product-citations-embeds January 17, 2024 14:18 Inactive
@duynguyen
Copy link
Collaborator

@davenichols-DHLS let's merge this PR and open a new issue for LHS improvement. It's because the TBT is quite high, caused by the jquery from bioz. However, it's only affecting the citations tab.

@davenichols-DHLS
Copy link
Collaborator

@davenichols-DHLS let's merge this PR and open a new issue for LHS improvement. It's because the TBT is quite high, caused by the jquery from bioz. However, it's only affecting the citations tab.

Excellent, I was thinking the same, I added the other tests and the main pages are great, it's just when loading bioz. I am happy to take this.

@davenichols-DHLS davenichols-DHLS merged commit ed7db3d into main Jan 17, 2024
1 of 2 checks passed
@davenichols-DHLS davenichols-DHLS deleted the 641-product-citations-embeds branch January 17, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Product] Product Family detail page - Citations embeds
3 participants