Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Base Path #29

Merged
merged 12 commits into from
Sep 10, 2024
Merged

Remove Base Path #29

merged 12 commits into from
Sep 10, 2024

Conversation

infloent
Copy link
Collaborator

@infloent infloent commented Jun 28, 2024

Remove base path

  • To check if this is really needed.
  • How will multi language/countries websites will be handled where country/language are part of the url.
  • How will we handle if an EDS website needs to be included as part of another site at specific path.

in all these case the base path had to be configured.

Test URLs:
Before: https://main--raqn-docs-sharepoint--henkel.aem.page/
After: https://general-improvements--raqn-docs-sharepoint--henkel.aem.page/

Copy link

aem-code-sync bot commented Jun 28, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jun 28, 2024

Page Scores Audits Google
M / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to general-improvements June 28, 2024 10:55 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to general-improvements July 31, 2024 13:28 Inactive
; Conflicts:
;	blocks/hero/hero.css
;	blocks/navigation/navigation.css
;	blocks/sidekick-tools-palette/sidekick-tools-palette.css
;	styles/styles.css
@aem-code-sync aem-code-sync bot temporarily deployed to general-improvements September 9, 2024 07:29 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to general-improvements September 9, 2024 07:39 Inactive
@infloent infloent changed the title Remove Base Path - Merge after new Sharepoint is ready [WIP] Remove Base Path - Merge after new Sharepoint is read Sep 9, 2024
@aem-code-sync aem-code-sync bot temporarily deployed to general-improvements September 9, 2024 10:33 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to general-improvements September 9, 2024 10:47 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to general-improvements September 9, 2024 10:49 Inactive
@infloent infloent changed the title [WIP] Remove Base Path - Merge after new Sharepoint is read Remove Base Path - Merge after new Sharepoint is read Sep 9, 2024
@infloent infloent changed the title Remove Base Path - Merge after new Sharepoint is read Remove Base Path Sep 9, 2024
@infloent infloent merged commit 8e238eb into main Sep 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants