Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Featured Article component does not pull title and description from the referenced article #39

Closed
blefebvre opened this issue Sep 21, 2023 · 0 comments · Fixed by #40
Closed

Featured Article component does not pull title and description from the referenced article #39

blefebvre opened this issue Sep 21, 2023 · 0 comments · Fixed by #40
Assignees
@blefebvre

Comments

@blefebvre
Copy link
Collaborator

Note how this featured article gets the title "Magazine" when used on the Magazine page:

Screenshot 2023-09-21 at 2 01 23 PM
@blefebvre blefebvre self-assigned this Sep 21, 2023
blefebvre added a commit to blefebvre/wknd that referenced this issue Sep 21, 2023
@blefebvre
hlxsites#39 - Featured Article component does not pull title and desc…
6bb0988 
…ription from the referenced article

Update sample authoring documents in documents.zip
@blefebvre blefebvre mentioned this issue Sep 21, 2023
Merged
blefebvre added a commit to blefebvre/wknd that referenced this issue Sep 22, 2023
@blefebvre
hlxsites#39 - Featured Article component does not pull title and desc…
6726745 
…ription from the referenced article

Move getMetadata override which accepts a document as 2nd parameter to featured-article.js to avoid changing lib-franklin.js
blefebvre added a commit that referenced this issue Sep 22, 2023
@blefebvre
#39 - Featured Article component does not pull title and description …
ffef8f0 
…from the referenced article (#40)

Move getMetadata override (which accepts a document as 2nd parameter) to featured-article.js to avoid changing lib-franklin.js
Update sample authoring documents in documents.zip
FentPams added a commit that referenced this issue Aug 7, 2024
@FentPams
Squashed 'plugins/experimentation/' changes from 9db8662..942948d
6d370f4 
942948d Update: Extract customized names from 'Experiment Variant Name(s)' in page metadata (#41)
5f942a2 feat: Add decoration handler for handling fragment decoration (#39)
9b4478d feat: Central host UI files (#40)

git-subtree-dir: plugins/experimentation
git-subtree-split: 942948d6334265d74d2bfa1342ec015a4c0c64ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blefebvre blefebvre

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@blefebvre