chore: implement blockquote block #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
|
fkakatie
reviewed
Feb 8, 2023
Comment on lines
228
to
235
| main blockquote { | ||
| font-style: italic; | ||
| color: var(--blockquote-color); | ||
| background-color: var(--blockquote-background-color); | ||
| font-family: var(--heading-font-family); | ||
| margin: 3rem; | ||
| text-indent: -1rem; | ||
| hanging-punctuation: first; | ||
| } |
There was a problem hiding this comment.
I would personally move this out of styles.css and into blockquote.css.
|
Is this first column necessary? From my perspective, this adds complexity to the authoring experience.
|
fkakatie
reviewed
Feb 8, 2023
fkakatie
approved these changes
Feb 8, 2023
|
Change the block structure. No first column, only quote text and optionally author. See https://quote--wknd--hlxsites.hlx.page/drafts/mhaack/test/western-australia |
|
ramboz
added a commit
that referenced
this pull request
Oct 27, 2023
be2e07d doc: update README.md 287e35f feat: adopt the plugin api (#2) 9028520 fix: possible css leaking into pill overlay 162aab2 fix: improve anonymization for better gdpr/hippa compliance (#3) 0071dbd fix: audience pill activation a486023 fix: audience parsing 4789afd feat: limit the sampling rate 7fbef36 feat: limit the sampling rate (#1) 92e2abb fix: campaigns parsing 4467d3e fix: block-level experiments resolution 4438f52 doc: update readme 44a3aa4 fix: support installation in sub-directories a77433f style: properly inherit text color in the overlay git-subtree-dir: plugins/experience-decisioning git-subtree-split: be2e07ddce1d9c8d1622e6221f7a16593d87b811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test URLs: