Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#30 - Include document sources to enable a user to explore the "document based authoring" capability #32

Closed
wants to merge 1 commit into from

Conversation

blefebvre
Copy link
Collaborator

Fix #30

  • Add document sources to the repo
  • Use .live domain for traffic generation instead of .page

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 14, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@cpilsworth
Copy link
Collaborator

cpilsworth commented Sep 15, 2023

Should the /docs/authoring folder be added to .hlxignore so it doesn't get deployed?

Copy link
Collaborator

@ramboz ramboz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are all binary files for git, I wonder if adding them directly in the repo is the best option. I fear this may bloat the repo size exponentially as we make updates to those.
Do we need to explicitly track all changes to those?

If not, we may consider a few alternatives, such as:

  • Using Git LFS
  • Attaching a zip file to a release
  • Uploading a zip with the files directly to drive

Looks good otherwise

@blefebvre
Copy link
Collaborator Author

Thanks @ramboz and @cpilsworth, I like the look of Git LFS so will close this PR and open another using that approach and a .zip archive of the documents.

@blefebvre blefebvre closed this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include document sources to enable a user to explore the "document based authoring" capability
3 participants