chore: update the experimentation plugin to the latest version #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-subtree-dir: plugins/experimentation git-subtree-split: 1e34eaeb3a5838c559255ca761242427efd28b50
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
ramboz
requested review from
iuliag,
trieloff,
tripodsan,
rofe,
mhaack and
dylandepass
iuliag
reviewed
Nov 27, 2023
There was a problem hiding this comment.
LGTM in terms of code changes.
2 things I noticed while validating that require configuration outside of this PR or better alignment:
- adjust headers to be able to get and show the experimentation results from RUM
- console log says experimentation will not run and pill is gray, though selected variant in
window.hlx.experimentis one of the challengers
|
@iuliag thanks for the feedback! |
d2028dc fix: simulation should work even if audience is not resolved f0904be fix: typo in readme git-subtree-dir: plugins/experimentation git-subtree-split: d2028dca464571ddbd6791099462b7708523a5bc
…xperimentaion-plugin
|
iuliag
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just updating the reference to the experimentation plugin to its latest version that contains a few bug fixes.
Test url: https://update-experimentaion-plugin--wknd--hlxsites.hlx.live/