Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Generate Variations Sidekick plugin config #51

Merged
merged 2 commits into from
Nov 30, 2023
Merged

feat: Add Generate Variations Sidekick plugin config #51

merged 2 commits into from
Nov 30, 2023

Conversation

askayastha22
Copy link
Contributor

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #49

Test URLs:

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 30, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 30, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@basecode basecode self-requested a review November 30, 2023 18:39
basecode
basecode approved these changes Nov 30, 2023
View reviewed changes
Copy link

@basecode basecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I'd remove "isPalette": false

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 30, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

ddragosd
ddragosd approved these changes Nov 30, 2023
View reviewed changes
Copy link

@ddragosd ddragosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@askayastha22 askayastha22 merged commit 9bdfa21 into main Nov 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddragosd ddragosd ddragosd approved these changes

@basecode basecode basecode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Generate Variations Sidekick plugin
3 participants
@askayastha22 @basecode @ddragosd