Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(martech): instrument the aem martech library for proper integration with Target and Analytics #76

Draft
wants to merge 64 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
3bbc98a
feat: introduce adobe core martech stack
ramboz Mar 20, 2024
8febbdf
feat: introduce adobe core martech stack
ramboz Mar 21, 2024
51f8099
feat: introduce adobe core martech stack
ramboz Mar 21, 2024
2f2a542
feat: introduce adobe core martech stack
ramboz Mar 21, 2024
a09af06
feat: introduce adobe core martech stack
ramboz Mar 21, 2024
2dd8077
feat: introduce adobe core martech stack
ramboz Mar 21, 2024
16e1858
feat: introduce adobe core martech stack
ramboz Mar 21, 2024
715195c
feat: introduce adobe core martech stack
ramboz Mar 21, 2024
0b341b1
feat: introduce adobe core martech stack
ramboz Mar 21, 2024
234d5bc
feat: introduce adobe core martech stack
ramboz Mar 21, 2024
cc7ed44
feat: introduce adobe core martech stack
ramboz Mar 21, 2024
f848cc5
feat: introduce adobe core martech stack
ramboz Mar 21, 2024
f8fc49e
feat: introduce adobe core martech stack
ramboz Mar 21, 2024
0930fe3
feat: introduce adobe core martech stack
ramboz Mar 21, 2024
2c690a5
chore: clean up codebase
ramboz Mar 22, 2024
dad4dea
chore: clean up codebase
ramboz Mar 22, 2024
3fd2637
fix: various refactoring
ramboz Apr 3, 2024
8d433e6
fix: export sendAnalyticsEvent method so it can be used without the d…
ramboz Apr 3, 2024
f1f8668
feat: introduce adobe core martech stack
ramboz Apr 5, 2024
e0d8491
feat: use proper launch config
ramboz Apr 6, 2024
4119f87
fix: apply eager amrtech while waiting for LCP
ramboz Apr 6, 2024
8e9b33f
refactor: alloy polyfill
ramboz Apr 6, 2024
6681521
fix: applied propositions are not properly reported
ramboz Apr 6, 2024
55b4479
fix: preconnect header
ramboz Apr 7, 2024
b833e61
fix: preconnect header
ramboz Apr 7, 2024
e8be996
fix: preconnect header
ramboz Apr 7, 2024
7214cd4
fix: defer alloy loading and config if target is disabled
ramboz Apr 8, 2024
d47e310
fix: defer alloy loading and config if target is disabled
ramboz Apr 8, 2024
1ae3e71
fix: defer alloy loading and config if target is disabled
ramboz Apr 8, 2024
4a63f0d
fix: defer alloy loading and config if target is disabled
ramboz Apr 8, 2024
2266fe4
fix: defer alloy loading and config if target is disabled
ramboz Apr 8, 2024
11ff984
fix: defer alloy loading and config if target is disabled
ramboz Apr 8, 2024
24dcd0c
fix: defer alloy loading and config if target is disabled
ramboz Apr 8, 2024
14636f6
fix: defer alloy loading and config if target is disabled
ramboz Apr 8, 2024
f339882
fix: defer alloy loading and config if target is disabled
ramboz Apr 8, 2024
9c32261
refactor: optimize code
ramboz Apr 8, 2024
662dbc4
Squashed 'plugins/martech/' content from commit f3bad2d
ramboz Jun 6, 2024
221bd25
Merge commit '662dbc4f36518b6018b3289152e8a176c72ec385' as 'plugins/m…
ramboz Jun 6, 2024
bb9bc18
feat: push key RUM events to datalayer
ramboz Jun 6, 2024
aac9681
fix: address PR feedback
ramboz Jun 7, 2024
989e369
fix: address PR feedback
ramboz Jun 7, 2024
c813ddc
fix: address PR feedback
ramboz Jun 7, 2024
2f90398
fix: address PR feedback
ramboz Jun 7, 2024
8d11ec0
fix: address PR feedback
ramboz Jun 7, 2024
ca6dc35
fix: address PR feedback
ramboz Jun 7, 2024
aaee962
fix: address PR feedback
ramboz Jun 11, 2024
222ae9c
fix: address PR feedback
ramboz Jun 11, 2024
301afed
fix: address PR feedback
ramboz Jun 11, 2024
48939ec
fix: address PR feedback
ramboz Jun 12, 2024
c6b8498
fix: remove non compliant analytics data
ramboz Jun 14, 2024
d42119f
fix: possible error on undefined propositions
ramboz Jun 17, 2024
46bda43
fix: user consent update
ramboz Jun 18, 2024
f4edead
fix: default tracked analytics metrics
ramboz Jun 18, 2024
75637b7
fix: 404 analytics tracking
ramboz Jun 18, 2024
7ad6915
fix: campaign reporting
ramboz Jun 18, 2024
1d15ff3
fix: 404 page metadata
ramboz Jun 19, 2024
9311ba1
fix: 404 page metadata
ramboz Jun 19, 2024
9e1078c
fix: address PR feedback
ramboz Jun 20, 2024
252512e
fix: form config isn't properly converted to valida data attributes
ramboz Jun 20, 2024
7e3fdfc
fix: form data layer events
ramboz Jun 20, 2024
f9ee27f
feat: track form submissions in analatics context data
ramboz Jun 24, 2024
2ed7e54
fix: default to empty xdm and data in the alloy payload
ramboz Jun 25, 2024
ec27e48
update martech lib
ramboz Jul 19, 2024
d75a41e
refactor: fix linting issues
ramboz Jul 19, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion 404.html
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
</script>
<meta name="viewport" content="width=device-width, initial-scale=1">
<meta property="og:title" content="Page not found">
<script src="/scripts/scripts.js" type="module" crossorigin="use-credentials"></script>
<script type="module" src="/scripts/lib-franklin.js"></script>
<script type="module" src="/scripts/scripts.js"></script>
<script type="module">
import { sampleRUM } from '/scripts/lib-franklin.js';

Expand Down Expand Up @@ -46,6 +47,9 @@
}
</style>
<link rel="stylesheet" href="/styles/lazy-styles.css">
<link rel="preload" as="script" crossorigin="anonymous" href="/scripts/adobe-martech/index.js"></script>
<link rel="preload" as="script" crossorigin="anonymous" href="/scripts/adobe-martech/alloy.min.js"></script>
<link rel="preconnect" crossorigin="with-crdentials" href="https://edge.adobedc.net"></script>
</head>

<body>
Expand Down
6 changes: 4 additions & 2 deletions blocks/form/form.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { readBlockConfig } from '../../scripts/lib-franklin.js';
import { readBlockConfig, toCamelCase } from '../../scripts/lib-franklin.js';

function generateUnique() {
return new Date().valueOf() + Math.random();
Expand Down Expand Up @@ -32,7 +32,7 @@
}

async function submissionFailure(error, form) {
alert(error); // TODO define error mechansim

Check warning on line 35 in blocks/form/form.js

View workflow job for this annotation

GitHub Actions / build

Unexpected alert
form.setAttribute('data-submitting', 'false');
form.querySelector('button[type="submit"]').disabled = false;
}
Expand Down Expand Up @@ -418,6 +418,8 @@
formLink.replaceWith(form);

const config = readBlockConfig(block);
Object.entries(config).forEach(([key, value]) => { if (value) form.dataset[key] = value; });
Object.entries(config).forEach(([key, value]) => {
if (value) form.dataset[toCamelCase(key)] = value;
});
}
}
6 changes: 5 additions & 1 deletion head.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
<meta name="viewport" content="width=device-width, initial-scale=1"/>
<script src="/scripts/scripts.js" type="module"></script>
<script type="module" src="/scripts/lib-franklin.js"></script>
<script type="module" src="/scripts/scripts.js"></script>
<link rel="stylesheet" href="/styles/styles.css"/>
<link rel="icon" href="data:,">
<link rel="preload" as="script" crossorigin="anonymous" href="/scripts/adobe-martech/index.js"/>
<link rel="preload" as="script" crossorigin="anonymous" href="/scripts/adobe-martech/alloy.min.js"/>
<link rel="preconnect" href="https://edge.adobedc.net"/>
1 change: 1 addition & 0 deletions scripts/adobe-martech/acdl.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 20 additions & 0 deletions scripts/adobe-martech/alloy.min.js

Large diffs are not rendered by default.

Loading
Loading