Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dirty entity tracking & updating #221

Closed
wants to merge 10 commits into from
Closed

Dirty entity tracking & updating #221

wants to merge 10 commits into from

Conversation

hmans
Copy link
Owner

@hmans hmans commented Oct 30, 2022 •
edited
Loading

  • ✅ Marking entities as dirty is fun and easy
  • ⛔ Marking entities as dirty and reindexing them costs performance. (This in itself is okay, but there is a risk that once we offer this sort of API, users will quickly use it a little too much.)
  • ⛔ This could also be done in userland (a system directly running test(entity) on buckets that expect this)

@codesandbox
Copy link

codesandbox bot commented Oct 30, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 96c9686

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hmans hmans linked an issue Oct 30, 2022 that may be closed by this pull request
[2.0] Update entities, mark as dirty, reindex #220
Open
@hmans
Merge branch 'main' into dirty-tracking
c7a273c 
* main:
  Tweak predicate check on addition
hmans added 2 commits October 30, 2022 21:45
@hmans
Merge branch 'main' into dirty-tracking
48ba115 
* main:
  Actions!
  applyDamage
  [React] useOnEntityRemoved/Added
  Move subasteroid spawning into its own system
  Add some new helpers
  Add another test
  Revert "Tweak predicate check on addition"
  Tweak initial entity registration
@hmans
Merge branch 'main' into dirty-tracking
96c9686 
* main: (24 commits)
  Fix changeset
  Update more development dependencies
  Upgrade development dependencies
  tag -> tagged
  New entity narrowing types (#224)
  tag
  Version Packages (next) (#222)
  Cleanup
  Fix types
  Add funding.yml
  Codedocs
  Cleanup
  Remove some uses of WithComponent
  Cleanup
  Remove IEntity!
  Don't use IEntity
  Codedocs for SegmentedBucket
  Cleanup
  Cleanup
  Cleanup
  ...
@hmans hmans closed this Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2.0] Update entities, mark as dirty, reindex
1 participant
@hmans