Fix disappearing asteroids and bullets #289
Conversation
|
This branch is running in CodeSandbox. Use the links below to review this PR faster. |
|
| Name | Type |
|---|---|
| @miniplex/bucket | Patch |
| @miniplex/core | Patch |
| @miniplex/react | Patch |
| miniplex | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
|
Thank you very much for the PR -- something having changed in the frustum culling behavior of Three.js' |
|
I think the build pipeline is just being a little weird, so I'm merging this now. The other regression I need to look at is the reduction in resolution, this might be anything between the Composer Suite libraries I'm using (Render Composer specifically) and Three.js, possibly |
|
I think users of the library would appreciate the reduction in moving parts, especially since the demo also serves as documentation, doubly so while things are in flux. The demo looks really good though, so there's probably room for a separate 'all out' demo of ECS + other technologies you've been developing :) Thanks for merging! |
|
Seems like the deployment for the previews works just fine, so I wonder what's up with the main deployment? |
This fixes the issue described #287, where the asteroids and bullets disappeared after a while. It turns out they were frustum culled once the player moved too far away from the starting position and the original geometry went out of the camera's frustum.
I didn't dig into why this has only started happening recently, but I did check out 26d6682, and can confirm that it did not happen there, but also the
InstancedParticlesmeshesfrustumCulledwasfalsethere, whereas it was/istrueon latestmain.