Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new player for media and entrance with support for playing events when music is playing #23

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

hmathieu31
Copy link
Owner

Remove seperate GetPlayer method and create a new BotaPlayer inheriting VotePlayer

  • Pauses tracks to play EntranceEvents and resume
  • Keeps queue

…ng VotePlayer

- Pauses tracks to play EntranceEvents and resume
- Keeps queue
@hmathieu31 hmathieu31 enabled auto-merge November 5, 2023 10:45
Copy link

sonarqubecloud bot commented Nov 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@hmathieu31 hmathieu31 merged commit 7f32ee1 into master Nov 5, 2023
4 checks passed
@hmathieu31 hmathieu31 deleted the fix/remove-grandEntrance-player branch November 5, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant