Adam Dunlap Submission #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "wk0-starter" | |||
| version = "0.1.0" | |||
| authors = ["Alex Ozdemir <aozdemir@hmc.edu>"] | |||
| authors = ["Adam Dulnap <adunlap@hmc.edu>"] | |||
There was a problem hiding this comment.
Nice! You found the Cargo.toml!
Also, I want to meet this Adam Dulnap kid -- seems pretty cool!
| @@ -1,11 +1,12 @@ | |||
| // Alex Ozdemir <aozdemir@hmc.edu> // <- Your name should replace this line! | |||
| // Adam Dunlap <adunlap@hmc.edU> | |||
| // Starter code for HMC's MemorySafe, week 0 | |||
| @@ -45,11 +47,14 @@ enum Peg { | |||
| enum Action { | |||
| /// Do this move | |||
| Move(Move), | |||
| /// Make an automatic move | |||
| Auto, | |||
| /// Quit the game | ||
| Quit, | ||
| } | ||
|
|
||
| /// The next step the game should take. Produced after a user instruction is processed. | ||
| /// The next step the game should take. Produced after a user instruction is | ||
| /// processed. |
There was a problem hiding this comment.
Rust convention is 99 character lines (not 80, or 100 for that matter).
| 'c' => Peg::Center, | ||
| 'r' => Peg::Right, | ||
| _ => return Err(HanoiError::UnknownCommand), | ||
| }; |
There was a problem hiding this comment.
Probably could remove this duplication. A function?
| } | ||
|
|
||
| impl State { | ||
|
|
||
| /// Creates a Towers of Hanoi game with `disks` disks in a single tower | ||
| fn new(disks: u8) -> State { | ||
| unimplemented!() | ||
| State{left: (1..disks+1).rev().map(|n| Disk(n)).collect(), | ||
| center: Vec::new(), right: Vec::new()} |
There was a problem hiding this comment.
😄
Point-free would be even cooler!
| // disk is on, or right peg if not). Next, find the largest disk n that | ||
| // is not on the destination peg. If we can move it, do so. Otherwise, | ||
| // recurse trying to move the n-1 disk to the peg that is neither the | ||
| // destination peg nor n's peg. |
There was a problem hiding this comment.
Thanks for the explanation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type "a" to make the first move on a shortest path to a victory.