Eric Mueller submission #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'c' => Ok(Peg::Center), | ||
| 'r' => Ok(Peg::Right), | ||
| _ => Err(HanoiError::UnknownCommand), | ||
| }; |
There was a problem hiding this comment.
Per your question in class, this could've been a function.
| } | ||
|
|
||
| const STARTING_PEG: Peg = Peg::Left; |
| // Despite all of our types being `Copy`, `Vec::last` still borrows the last element, so we | ||
| // need to explicitly clone it. | ||
| // Despite all of our types being `Copy`, `Vec::last` still borrows | ||
| // the last element, so we need to explicitly clone it. |
There was a problem hiding this comment.
The Rust convention is 99 character lines, rather than 80.
| // unwrap is okay since we know we have something to pop | ||
| self.pop_disk(from).unwrap(); | ||
| Ok(()) | ||
| })); |
There was a problem hiding this comment.
Doing the pop after the try!(push_disk) should be equivalent. Good to see you're comfortable with and_then though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.