Michael Sheely Pull Request #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let from = chars.next().and_then(char_to_peg); | ||
| let to = chars.next().and_then(char_to_peg); | ||
| match (from, to, chars.next()) { | ||
| (Some(from_peg), Some(to_peg), None) => Ok(Action::Move(Move::new(from_peg, to_peg))), |
There was a problem hiding this comment.
This is awesome. Jackson and I are looking at how people did parsing and I really like your match on a 3-tuple.
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "wk0-starter" | |||
| version = "0.1.0" | |||
| authors = ["Alex Ozdemir <aozdemir@hmc.edu>"] | |||
| authors = ["Alex Ozdemir <aozdemir@hmc.edu>", "Michael Sheely <msheely@hmc.edu>"] | |||
There was a problem hiding this comment.
Oh man!
You found the Cargo.toml!
| // It has been completed by Michael Sheely to form | ||
| // a functional command line game: Towers of Hanoi | ||
| // | ||
| // Talked to Jackson Warely and Adam Dunlap |
| let mut vec = Vec::new(); | ||
| for i in 0..disks { | ||
| vec.push(Disk(disks - i)); | ||
| } |
There was a problem hiding this comment.
Definitely works! You can also take of the advantage of the fact that 0..disks is Iterator<i32> and use Iterator::collect to pull the items in the iterator into a vector.
| Peg::Left => self.left.push(disk), | ||
| Peg::Center => self.center.push(disk), | ||
| Peg::Right => self.right.push(disk), | ||
| }) |
There was a problem hiding this comment.
You may have already written code for this.
|
|
||
| /// Returns the next step of the algorithm, based on if we're done or not | ||
| fn next_step(&self) -> NextStep { | ||
| if self.done() { NextStep::Win } else { NextStep::Continue } | ||
| } |
| match result { | ||
| Ok(()) => { self.pop_disk(from); Ok(self.next_step()) }, | ||
| Err(e) => Err(e), | ||
| } |
There was a problem hiding this comment.
Hmm... If it's Ok do something, else pass the error though... Have we seen this pattern?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.