generated from hmcts/spring-boot-template
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DTSAM-583 Fix non-running integration tests #2361
Merged
mikebrownccd
merged 2 commits into
DTSAM-574__RAS_query_API_optional_include_role_labels
from
DTSAM-583__Integration_Test_Patch
Oct 22, 2024
Merged
DTSAM-583 Fix non-running integration tests #2361
mikebrownccd
merged 2 commits into
DTSAM-574__RAS_query_API_optional_include_role_labels
from
DTSAM-583__Integration_Test_Patch
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[DTSAM-583](https://tools.hmcts.net/jira/browse/DTSAM-583) Fix non-running integration tests.
Plan Result (aat)
|
Plan Result (prod)
|
…into DTSAM-583__Integration_Test_Patch
rajkatla-hmcts
approved these changes
Oct 21, 2024
abul-syed
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
mikebrownccd
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6289942
into
DTSAM-574__RAS_query_API_optional_include_role_labels
5 checks passed
mikebrownccd
pushed a commit
that referenced
this pull request
Oct 22, 2024
* DTSAM-574 add optional roleLabel in RAS query APIs response * DTSAM-574 add sonar issue + tidy up * DTSAM-574 fetch `RoleConfig` outside forEach & null check `RoleConfigRole` * DTSAM-574 revert JacksonUtils.java changes * DTSAM-574 update IT * DTSAM-574 update `RoleAssignmentIntegrationTest.java` imports * DTSAM-574 review feedback (move duplicate code to method) * DTSAM-574 FTA added scenario for v1 & 2 query req with includeLabels (#2359) * DTSAM-574 FTA added scenario for v1 query req with includeLabels * DTSAM-574 FTA added scenario for v2 query req with includeLabels * DTSAM-574 update S-185 FTA * DTSAM-574 update S-185 FTA * DTSAM-574 update S-185 FTA * DTSAM-574 add `__ordering__` & `__elementId__` S-185 FTA * DTSAM-574 update S-185 * DTSAM-574 delete RoleAssignments for s-185 * DTSAM-574 review feedback (generate UUID for reference) * DTSAM-583 Fix non-running integration tests (#2361) [DTSAM-583](https://tools.hmcts.net/jira/browse/DTSAM-583) Fix non-running integration tests. --------- Co-authored-by: Matt Nayler <57350764+mattnayler@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
DTSAM-583 "Resolve issue with non-running RAS Integration Tests"
Change description
Fix non-running integration tests.
Does this PR introduce a breaking change? (check one with "x")