Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTSAM-583 Fix non-running integration tests #2361

Conversation

mattnayler
Copy link
Contributor

JIRA link (if applicable)

DTSAM-583 "Resolve issue with non-running RAS Integration Tests"

Change description

Fix non-running integration tests.

This has been written as a patch t oDTSAM-574: see #2355

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

@hmcts-jenkins-a-to-c
Copy link
Contributor

Plan Result (aat)

No changes. Your infrastructure matches the configuration.

@hmcts-jenkins-a-to-c
Copy link
Contributor

Plan Result (prod)

No changes. Your infrastructure matches the configuration.

@mattnayler mattnayler marked this pull request as ready for review October 21, 2024 11:44
Copy link
Contributor

@abul-syed abul-syed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@mikebrownccd mikebrownccd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrownccd mikebrownccd merged commit 6289942 into DTSAM-574__RAS_query_API_optional_include_role_labels Oct 22, 2024
5 checks passed
@mikebrownccd mikebrownccd deleted the DTSAM-583__Integration_Test_Patch branch October 22, 2024 08:43
mikebrownccd pushed a commit that referenced this pull request Oct 22, 2024
* DTSAM-574 add optional roleLabel in RAS query APIs response

* DTSAM-574 add sonar issue + tidy up

* DTSAM-574 fetch `RoleConfig` outside forEach & null check `RoleConfigRole`

* DTSAM-574 revert JacksonUtils.java changes

* DTSAM-574 update IT

* DTSAM-574 update `RoleAssignmentIntegrationTest.java` imports

* DTSAM-574 review feedback (move duplicate code to method)

* DTSAM-574 FTA added scenario for v1 & 2 query req with includeLabels (#2359)

* DTSAM-574 FTA added scenario for v1 query req with includeLabels

* DTSAM-574 FTA added scenario for v2 query req with includeLabels

* DTSAM-574 update S-185 FTA

* DTSAM-574 update S-185 FTA

* DTSAM-574 update S-185 FTA

* DTSAM-574 add `__ordering__` & `__elementId__` S-185 FTA

* DTSAM-574 update S-185

* DTSAM-574 delete RoleAssignments for s-185

* DTSAM-574 review feedback (generate UUID for reference)

* DTSAM-583 Fix non-running integration tests (#2361)

[DTSAM-583](https://tools.hmcts.net/jira/browse/DTSAM-583)

Fix non-running integration tests.

---------

Co-authored-by: Matt Nayler <57350764+mattnayler@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants