Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DTSPO-22341 #884

Merged
merged 4 commits into from
Nov 20, 2024
Merged

DTSPO-22341 #884

merged 4 commits into from
Nov 20, 2024

Conversation

JordanHoey96
Copy link
Contributor

Jira link

DTSPO-22341

Change description

  • Adding var to ensure "Get issue body" targets the correct repo for when this is running in dev.
  • Updating resource-details.sh to work with new MS Graph functions (removing dependancy on subscriptions)
  • Removing unused code from resource-details.sh

Testing done

Tested in dev
To be monitored.

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

@JordanHoey96 JordanHoey96 requested a review from a team as a code owner November 20, 2024 15:14
@JordanHoey96 JordanHoey96 requested review from madjava, cpareek and ashleighB31 and removed request for a team November 20, 2024 15:14
@JordanHoey96 JordanHoey96 merged commit 9e9304b into master Nov 20, 2024
1 check passed
@JordanHoey96 JordanHoey96 deleted the DTSPO-22341 branch November 20, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ieuanb74 ieuanb74 ieuanb74 approved these changes

@madjava madjava Awaiting requested review from madjava madjava is a code owner automatically assigned from hmcts/platform-operations

@cpareek cpareek Awaiting requested review from cpareek cpareek is a code owner automatically assigned from hmcts/platform-operations

@ashleighB31 ashleighB31 Awaiting requested review from ashleighB31 ashleighB31 is a code owner automatically assigned from hmcts/platform-operations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JordanHoey96 @ieuanb74