Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDM-5301 - yarn audit with suppression script #236

Merged
merged 5 commits into from
Jul 26, 2019
Merged

Conversation

smathangi
Copy link
Contributor

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/RDM-5301

Change description

This change adds yarn test:audit to build pipeline as part of the security check steps. This uses a bash script to run yarn audit and compare any vulnerabilities found against a known issue list. Therefore the build will now break on PR build if any vulnerable tools are introduced / new vulnerabilities found.

Note: There is an outstanding feature request for Yarn to be able to suppress vulnerabilities so once that's been introduced the run-yarn-audit.sh script can be removed (yarnpkg/yarn#6669)

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ x] No

@codecov
Copy link

codecov bot commented Jul 22, 2019

Codecov Report

Merging #236 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #236   +/-   ##
=======================================
  Coverage   87.41%   87.41%           
=======================================
  Files          14       14           
  Lines         286      286           
  Branches       39       39           
=======================================
  Hits          250      250           
  Misses         36       36

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f37ab3...bfbff46. Read the comment docs.

@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview July 22, 2019 12:23 Inactive
Copy link
Contributor

@MSancaktutar MSancaktutar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. Just a minor-most comment on echo messages..

bin/run-yarn-audit.sh Show resolved Hide resolved
@jenkins-reform-hmcts2 jenkins-reform-hmcts2 temporarily deployed to preview July 26, 2019 06:34 Inactive
@hemantt hemantt merged commit f901e38 into master Jul 26, 2019
@hemantt hemantt deleted the RDM-5330_ng_audit branch July 26, 2019 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants