Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCD-5327 - Updated DEFINITION_STORE_S2S_AUTHORISED_SERVICES variable to include … #1513

Merged

Conversation

patelila
Copy link
Contributor

…xui_webapp.

Also added a test for EventEnablingCondition to test combination of AND|OR

Before creating a pull request make sure that:

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • the keep-helm label has been added, if the helm release should be persisted after a successful build

Please remove this line and everything above and fill the following sections:

JIRA link (if applicable)

Change description

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

…xui_webapp.

Also added a test for EventEnablingCondition to test combination of AND|OR
@patelila patelila added keep-helm Do Not Uninstall Helm Release on Success enable_keep_helm labels Oct 17, 2024
Copy link
Contributor

@aktaskaan aktaskaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dinesh1patel dinesh1patel merged commit 3d55c05 into master Nov 11, 2024
4 checks passed
@dinesh1patel dinesh1patel deleted the CCD-5327_Whitelist_xuiwebapp_CCD_Definition_store branch November 11, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enable_keep_helm keep-helm Do Not Uninstall Helm Release on Success ns:ccd prd:ccd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants